Re: [libvirt] Domain XML format using defined storage volume + RFC

2008-05-20 Thread Stefan de Konink
Daniel P. Berrange schreef: and a volume can be either a file or a physical device, so fixing it to be 'phy:' is not correct. How can we know if the volume is a file or a device? virStorageVolGetInfo() will tell you via the 'info' field of the struct it fills As attached. I updated the 'typ'

Re: [libvirt] Domain XML format using defined storage volume + RFC

2008-05-20 Thread Daniel P. Berrange
On Mon, May 19, 2008 at 11:53:07PM +0200, Stefan de Konink wrote: > Daniel P. Berrange schreef: > >On Fri, May 16, 2008 at 01:00:16AM +0200, Stefan de Konink wrote: > > > >>+} > >>+} > >>+} > >> } else if ((target == NULL) && >

Re: [libvirt] Domain XML format using defined storage volume + RFC

2008-05-19 Thread Stefan de Konink
Daniel P. Berrange schreef: On Fri, May 16, 2008 at 01:00:16AM +0200, Stefan de Konink wrote: On Thu, 15 May 2008, Stefan de Konink wrote: On Thu, 15 May 2008, Stefan de Konink wrote: I almost started crying why it didn't work. But it is fixed, and it works as a charm :) See updated patch!

Re: [libvirt] Domain XML format using defined storage volume + RFC

2008-05-19 Thread Daniel P. Berrange
On Fri, May 16, 2008 at 01:00:16AM +0200, Stefan de Konink wrote: > On Thu, 15 May 2008, Stefan de Konink wrote: > > > On Thu, 15 May 2008, Stefan de Konink wrote: > > > > > I almost started crying why it didn't work. But it is fixed, and it works > > > as a charm :) See updated patch! > > > > I g

Re: [libvirt] Domain XML format using defined storage volume + RFC

2008-05-19 Thread Stefan de Konink
Can this be added to cvs/git? Stefan On Fri, 16 May 2008, Stefan de Konink wrote: > On Thu, 15 May 2008, Stefan de Konink wrote: > > > On Thu, 15 May 2008, Stefan de Konink wrote: > > > > > I almost started crying why it didn't work. But it is fixed, and it works > > > as a charm :) See updated

Re: [libvirt] Domain XML format using defined storage volume + RFC

2008-05-15 Thread Stefan de Konink
And before I forget... If I would write a patch doing: Constistently fetching lun-0, would that be accepted? I see one problem that wasn't there with Xen. Xen knows when a node is gone, you do not. block-iscsi could logout for me, is there currently a management task i

Re: [libvirt] Domain XML format using defined storage volume + RFC

2008-05-15 Thread Stefan de Konink
On Thu, 15 May 2008, Stefan de Konink wrote: > On Thu, 15 May 2008, Stefan de Konink wrote: > > > I almost started crying why it didn't work. But it is fixed, and it works > > as a charm :) See updated patch! > > I guess I need to write the 'check' tool and documentation update too? Since there i

Re: [libvirt] Domain XML format using defined storage volume + RFC

2008-05-15 Thread Stefan de Konink
On Thu, 15 May 2008, Stefan de Konink wrote: > I almost started crying why it didn't work. But it is fixed, and it works > as a charm :) See updated patch! I guess I need to write the 'check' tool and documentation update too? Stefan -- Libvir-list mailing list Libvir-list@redhat.com https://w

Re: [libvirt] Domain XML format using defined storage volume + RFC

2008-05-15 Thread Stefan de Konink
I almost started crying why it didn't work. But it is fixed, and it works as a charm :) See updated patch! Sign-off-by: Stefan de Konink <[EMAIL PROTECTED]> Stefan ps. One extra suggestion: I would consider it a good thing if the virLog function in util.c would get a \n diff --git a/src/xml.c b

Re: [libvirt] Domain XML format using defined storage volume + RFC

2008-05-15 Thread Daniel P. Berrange
On Thu, May 15, 2008 at 03:58:33PM +0200, Stefan de Konink wrote: > On Thu, 15 May 2008, Daniel P. Berrange wrote: > > > A storage pool is not just SCSI. It can be a directory of ISO files, an NFS > > mount of ISO files, local device nodes (including CDROM). So it is perfectly > > possible that we

Re: [libvirt] Domain XML format using defined storage volume + RFC

2008-05-15 Thread Stefan de Konink
On Thu, 15 May 2008, Daniel P. Berrange wrote: > A storage pool is not just SCSI. It can be a directory of ISO files, an NFS > mount of ISO files, local device nodes (including CDROM). So it is perfectly > possible that we'll use a pool to back a virtual CD device. This is dealt > with by simply s

Re: [libvirt] Domain XML format using defined storage volume + RFC

2008-05-15 Thread Daniel P. Berrange
On Thu, May 15, 2008 at 03:37:14PM +0200, Stefan de Konink wrote: > On Thu, 15 May 2008, Daniel P. Berrange wrote: > > > On Thu, May 15, 2008 at 03:20:06PM +0200, Stefan de Konink wrote: > > > On Thu, 15 May 2008, Stefan de Konink wrote: > > > > > > > Now I wonder, is it possible to have here > >

Re: [libvirt] Domain XML format using defined storage volume + RFC

2008-05-15 Thread Stefan de Konink
On Thu, 15 May 2008, Daniel P. Berrange wrote: > On Thu, May 15, 2008 at 03:20:06PM +0200, Stefan de Konink wrote: > > On Thu, 15 May 2008, Stefan de Konink wrote: > > > > > Now I wonder, is it possible to have here > > > somethinglike storage://netapp/lun-0? > > > > > > > [snip] > > > > > From th

Re: [libvirt] Domain XML format using defined storage volume + RFC

2008-05-15 Thread Daniel P. Berrange
On Thu, May 15, 2008 at 03:20:06PM +0200, Stefan de Konink wrote: > On Thu, 15 May 2008, Stefan de Konink wrote: > > > Now I wonder, is it possible to have here > > somethinglike storage://netapp/lun-0? > > > > [snip] > > > From the standpoint: we make it easy for the user I would prefer not to

Re: [libvirt] Domain XML format using defined storage volume + RFC

2008-05-15 Thread Stefan de Konink
On Thu, 15 May 2008, Stefan de Konink wrote: > Now I wonder, is it possible to have here > somethinglike storage://netapp/lun-0? > [snip] > >From the standpoint: we make it easy for the user I would prefer not to > provide a Linux specific path. http://libvirt.org/formatdomain.html#elementsDisk