On Thu, Sep 24, 2009 at 01:02:24PM +0200, Chris Lalancette wrote:
> Charles Duffy wrote:
> > HACKING suggests compiling with --enable-compile-warnings=error before
> > submitting any patches; however, current master fails for me on this
> > account (CentOS 5.3; gcc 4.1.2).
> >
> > Please see att
Chris Lalancette wrote:
I didn't see the error about the virStrcpy one, so I would still be curious as
to what you are seeing there.
As the context of the patch implies, this was a link-time issue -- but I
find myself unable to reproduce it. I'll continue this thread should
that change in the
Charles Duffy wrote:
> HACKING suggests compiling with --enable-compile-warnings=error before
> submitting any patches; however, current master fails for me on this
> account (CentOS 5.3; gcc 4.1.2).
>
> Please see attached. I suspect most of these should be uncontroversial
> -- but wonder if p
Interesting that gcc-4.41 isn't giving me any warnings
On Wed, 2009-09-23 at 12:32 -0500, Charles Duffy wrote:
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index af215ca..25d983e 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -6132,7 +6132,7 @@ static
Chris Lalancette wrote:
> Charles Duffy wrote:
>> HACKING suggests compiling with --enable-compile-warnings=error before
>> submitting any patches; however, current master fails for me on this
>> account (CentOS 5.3; gcc 4.1.2).
>>
>> Please see attached. I suspect most of these should be uncontr
Charles Duffy wrote:
> HACKING suggests compiling with --enable-compile-warnings=error before
> submitting any patches; however, current master fails for me on this
> account (CentOS 5.3; gcc 4.1.2).
>
> Please see attached. I suspect most of these should be uncontroversial
> -- but wonder if p
HACKING suggests compiling with --enable-compile-warnings=error before
submitting any patches; however, current master fails for me on this
account (CentOS 5.3; gcc 4.1.2).
Please see attached. I suspect most of these should be uncontroversial
-- but wonder if perhaps virStrcpy uses would be b
