Re: [libvirt] PATCH: 19/25: Remove use of non-threadsafe POSIX apis

2009-01-22 Thread Jim Meyering
"Daniel P. Berrange" wrote: >> One problem in virGetUserDirectory. >> It always returns NULL. > > Yep, already fixed that. > >> And did you mean to include the TCP socket changes in this set? > > Yes, its require to remove the use of non-threadsafe gethostname() > call In that case, ACK. -- Libv

Re: [libvirt] PATCH: 19/25: Remove use of non-threadsafe POSIX apis

2009-01-22 Thread Daniel P. Berrange
On Thu, Jan 22, 2009 at 04:21:25PM +0100, Jim Meyering wrote: > "Daniel P. Berrange" wrote: > > On Fri, Jan 16, 2009 at 12:25:02PM +, Daniel P. Berrange wrote: > >> On Fri, Jan 16, 2009 at 12:21:59PM +, Richard W.M. Jones wrote: > >> > On Tue, Jan 13, 2009 at 05:46:37PM +, Daniel P. Be

Re: [libvirt] PATCH: 19/25: Remove use of non-threadsafe POSIX apis

2009-01-22 Thread Jim Meyering
"Daniel P. Berrange" wrote: > On Fri, Jan 16, 2009 at 12:25:02PM +, Daniel P. Berrange wrote: >> On Fri, Jan 16, 2009 at 12:21:59PM +, Richard W.M. Jones wrote: >> > On Tue, Jan 13, 2009 at 05:46:37PM +, Daniel P. Berrange wrote: >> > > +char buf[1024]; >> > >> > sysconf (_SC_G

Re: [libvirt] PATCH: 19/25: Remove use of non-threadsafe POSIX apis

2009-01-22 Thread Daniel P. Berrange
On Thu, Jan 22, 2009 at 10:48:59AM +, Daniel P. Berrange wrote: > On Fri, Jan 16, 2009 at 12:25:02PM +, Daniel P. Berrange wrote: > > On Fri, Jan 16, 2009 at 12:21:59PM +, Richard W.M. Jones wrote: > > > On Tue, Jan 13, 2009 at 05:46:37PM +, Daniel P. Berrange wrote: > > > > +

Re: [libvirt] PATCH: 19/25: Remove use of non-threadsafe POSIX apis

2009-01-22 Thread Richard W.M. Jones
On Thu, Jan 22, 2009 at 10:48:59AM +, Daniel P. Berrange wrote: > On Fri, Jan 16, 2009 at 12:25:02PM +, Daniel P. Berrange wrote: > > On Fri, Jan 16, 2009 at 12:21:59PM +, Richard W.M. Jones wrote: > > > On Tue, Jan 13, 2009 at 05:46:37PM +, Daniel P. Berrange wrote: > > > > +

Re: [libvirt] PATCH: 19/25: Remove use of non-threadsafe POSIX apis

2009-01-22 Thread Daniel P. Berrange
On Fri, Jan 16, 2009 at 12:25:02PM +, Daniel P. Berrange wrote: > On Fri, Jan 16, 2009 at 12:21:59PM +, Richard W.M. Jones wrote: > > On Tue, Jan 13, 2009 at 05:46:37PM +, Daniel P. Berrange wrote: > > > +char buf[1024]; > > > > sysconf (_SC_GETPW_R_SIZE_MAX)? > > > > Looking

Re: [libvirt] PATCH: 19/25: Remove use of non-threadsafe POSIX apis

2009-01-16 Thread Daniel Veillard
On Fri, Jan 16, 2009 at 12:25:02PM +, Daniel P. Berrange wrote: > On Fri, Jan 16, 2009 at 12:21:59PM +, Richard W.M. Jones wrote: > > On Tue, Jan 13, 2009 at 05:46:37PM +, Daniel P. Berrange wrote: > > > +char buf[1024]; > > > > sysconf (_SC_GETPW_R_SIZE_MAX)? > > > > Looking

Re: [libvirt] PATCH: 19/25: Remove use of non-threadsafe POSIX apis

2009-01-16 Thread Daniel P. Berrange
On Fri, Jan 16, 2009 at 12:21:59PM +, Richard W.M. Jones wrote: > On Tue, Jan 13, 2009 at 05:46:37PM +, Daniel P. Berrange wrote: > > +char buf[1024]; > > sysconf (_SC_GETPW_R_SIZE_MAX)? > > Looking at glibc's implementation of getpwuid (which uses getpwuid_r), > I see that glibc

Re: [libvirt] PATCH: 19/25: Remove use of non-threadsafe POSIX apis

2009-01-16 Thread Richard W.M. Jones
On Tue, Jan 13, 2009 at 05:46:37PM +, Daniel P. Berrange wrote: > +char buf[1024]; sysconf (_SC_GETPW_R_SIZE_MAX)? Looking at glibc's implementation of getpwuid (which uses getpwuid_r), I see that glibc dynamically reallocates the buffer as necessary to the correct size for the return

Re: [libvirt] PATCH: 19/25: Remove use of non-threadsafe POSIX apis

2009-01-13 Thread Daniel P. Berrange
Remove use of various non thread safe functions, specifically strtok getmntent getgrnam getpwuid gethostbyname I thought we also had to remove use of readdir(), but it turns out that *is* threadsafe provided you only use each DIR* object from one thread at a time, which is fine for our needs. T