Re: [libvirt] PATCH: 2/12: Make use of versioned linker scripts

2008-11-14 Thread Daniel Veillard
On Thu, Nov 13, 2008 at 09:44:42PM +, Daniel P. Berrange wrote: On Thu, Nov 13, 2008 at 06:31:04PM +0100, Daniel Veillard wrote: When I removed the __ from the 'private' symbols exported, this internal driver typedef now clashes with the following public symbol: okay, just one more

Re: [libvirt] PATCH: 2/12: Make use of versioned linker scripts

2008-11-14 Thread Daniel P. Berrange
On Thu, Nov 13, 2008 at 05:21:23PM +, Daniel P. Berrange wrote: This patch changes the way we use linker scripts to have fully versioned symbols, and a versioned private section for symbols needed by libvirtd and virsh. If you look at the version script below, you'll see that I've added

Re: [libvirt] PATCH: 2/12: Make use of versioned linker scripts

2008-11-14 Thread Daniel Veillard
On Fri, Nov 14, 2008 at 10:37:51AM +, Daniel P. Berrange wrote: On Thu, Nov 13, 2008 at 05:21:23PM +, Daniel P. Berrange wrote: This patch changes the way we use linker scripts to have fully versioned symbols, and a versioned private section for symbols needed by libvirtd and virsh.

Re: [libvirt] PATCH: 2/12: Make use of versioned linker scripts

2008-11-13 Thread Daniel P. Berrange
This patch changes the way we use linker scripts to have fully versioned symbols, and a versioned private section for symbols needed by libvirtd and virsh. Daniel diff -r bbf3d0bc9d49 configure.in --- a/configure.in Tue Nov 11 17:28:27 2008 + +++ b/configure.in Tue Nov 11 17:28:31

Re: [libvirt] PATCH: 2/12: Make use of versioned linker scripts

2008-11-13 Thread Daniel Veillard
On Thu, Nov 13, 2008 at 05:21:23PM +, Daniel P. Berrange wrote: This patch changes the way we use linker scripts to have fully versioned symbols, and a versioned private section for symbols needed by libvirtd and virsh. Just a couple of questions: +++ b/src/driver.hTue Nov 11

Re: [libvirt] PATCH: 2/12: Make use of versioned linker scripts

2008-11-13 Thread Daniel P. Berrange
On Thu, Nov 13, 2008 at 06:31:04PM +0100, Daniel Veillard wrote: On Thu, Nov 13, 2008 at 05:21:23PM +, Daniel P. Berrange wrote: This patch changes the way we use linker scripts to have fully versioned symbols, and a versioned private section for symbols needed by libvirtd and virsh.