Re: [libvirt] PATCH: 3/14: Generic domain XML parser/formatter

2008-07-24 Thread Daniel P. Berrange
On Fri, Jul 18, 2008 at 06:29:15PM +0200, Jim Meyering wrote: > > Looks like this can be replaced with virDomainChrTypeFromString. > > > +if (STREQ(type, "null")) > > +def->type = VIR_DOMAIN_CHR_TYPE_NULL; > > +else if (STREQ(type, "vc")) > > +def->type = VI

Re: [libvirt] PATCH: 3/14: Generic domain XML parser/formatter

2008-07-18 Thread Jim Meyering
... > +static virDomainChrDefPtr > +virDomainChrDefParseXML(virConnectPtr conn, > +xmlNodePtr node) { > +xmlNodePtr cur; > +char *type = NULL; > +char *bindHost = NULL; > +char *bindService = NULL; > +char *connectHost = NULL; > +char *connectService