Re: [libvirt] PATCH: Add NUMA apis to remote driver

2008-05-22 Thread Daniel P. Berrange
On Wed, May 21, 2008 at 05:18:49PM +0200, Jim Meyering wrote: > "Richard W.M. Jones" <[EMAIL PROTECTED]> wrote: > > On Tue, May 20, 2008 at 03:51:53PM +0100, Daniel P. Berrange wrote: > >> +if GLIBC_RPCGEN > >> + mv $@ [EMAIL PROTECTED] > >> + sed -e 's/\t//g' [EMAIL PROTECTED] > $@ > >>

Re: [libvirt] PATCH: Add NUMA apis to remote driver

2008-05-21 Thread Jim Meyering
"Richard W.M. Jones" <[EMAIL PROTECTED]> wrote: > On Tue, May 20, 2008 at 03:51:53PM +0100, Daniel P. Berrange wrote: >> +if GLIBC_RPCGEN >> +mv $@ [EMAIL PROTECTED] >> +sed -e 's/\t//g' [EMAIL PROTECTED] > $@ >> +endif > > I guess it doesn't matter in a generated file, but is the a

Re: [libvirt] PATCH: Add NUMA apis to remote driver

2008-05-21 Thread Richard W.M. Jones
On Tue, May 20, 2008 at 03:51:53PM +0100, Daniel P. Berrange wrote: > +if GLIBC_RPCGEN > + mv $@ [EMAIL PROTECTED] > + sed -e 's/\t//g' [EMAIL PROTECTED] > $@ > +endif I guess it doesn't matter in a generated file, but is the above correct? Probably better to use the 'expand' comm

Re: [libvirt] PATCH: Add NUMA apis to remote driver

2008-05-20 Thread Daniel P. Berrange
On Tue, May 20, 2008 at 02:18:37PM +0200, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > > On Tue, May 20, 2008 at 01:49:08PM +0200, Jim Meyering wrote: > >> > >> Looks fine. Though you'll want to undo the global > >> re-indentation-with-TABs in qemud/remote_protocol.h: >

Re: [libvirt] PATCH: Add NUMA apis to remote driver

2008-05-20 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > On Tue, May 20, 2008 at 01:49:08PM +0200, Jim Meyering wrote: >> "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: >> > For some reason the virNodeGetFreeMemroy and virNodeGetCellsFreeMemory >> > NUMA APIs were never added to the remote driver. THis

Re: [libvirt] PATCH: Add NUMA apis to remote driver

2008-05-20 Thread Daniel P. Berrange
On Tue, May 20, 2008 at 01:49:08PM +0200, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > > For some reason the virNodeGetFreeMemroy and virNodeGetCellsFreeMemory > > NUMA APIs were never added to the remote driver. THis patch fixes that. > > It also updates the 2 perl scrip

Re: [libvirt] PATCH: Add NUMA apis to remote driver

2008-05-20 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > For some reason the virNodeGetFreeMemroy and virNodeGetCellsFreeMemory > NUMA APIs were never added to the remote driver. THis patch fixes that. > It also updates the 2 perl scripts which post-process the RPC files to > not insert TABs, since we'd p

Re: [libvirt] PATCH: Add NUMA apis to remote driver

2008-05-19 Thread Richard W.M. Jones
On Thu, May 15, 2008 at 10:08:42PM +0100, Daniel P. Berrange wrote: > For some reason the virNodeGetFreeMemroy and virNodeGetCellsFreeMemory > NUMA APIs were never added to the remote driver. THis patch fixes that. > It also updates the 2 perl scripts which post-process the RPC files to > not inser