Re: [libvirt] PATCH: Ensure errors are guarenteed reported in virConnectOpen

2008-08-22 Thread Daniel Veillard
On Tue, Aug 19, 2008 at 11:35:18AM +0100, Daniel P. Berrange wrote: The virConnectOpen method is unfortuantely rather special. While there is a virConnect object available, the current rule is that drivers must report errors against the global error object, because upon failure no virConnect

Re: [libvirt] PATCH: Ensure errors are guarenteed reported in virConnectOpen

2008-08-21 Thread Daniel Veillard
On Wed, Aug 20, 2008 at 07:24:59PM +0100, Daniel P. Berrange wrote: On Wed, Aug 20, 2008 at 02:22:58PM +0100, Richard W.M. Jones wrote: On Tue, Aug 19, 2008 at 11:35:18AM +0100, Daniel P. Berrange wrote: The guarenteed correct solution is actually rather simple - Always report errors

Re: [libvirt] PATCH: Ensure errors are guarenteed reported in virConnectOpen

2008-08-21 Thread Jim Meyering
Daniel P. Berrange [EMAIL PROTECTED] wrote: The virConnectOpen method is unfortuantely rather special. While there is a virConnect object available, the current rule is that drivers must report errors against the global error object, because upon failure no virConnect object will be returned

Re: [libvirt] PATCH: Ensure errors are guarenteed reported in virConnectOpen

2008-08-21 Thread Daniel P. Berrange
On Thu, Aug 21, 2008 at 08:35:25AM +0200, Daniel Veillard wrote: On Wed, Aug 20, 2008 at 07:24:59PM +0100, Daniel P. Berrange wrote: On Wed, Aug 20, 2008 at 02:22:58PM +0100, Richard W.M. Jones wrote: On Tue, Aug 19, 2008 at 11:35:18AM +0100, Daniel P. Berrange wrote: The guarenteed

Re: [libvirt] PATCH: Ensure errors are guarenteed reported in virConnectOpen

2008-08-21 Thread Daniel Veillard
On Thu, Aug 21, 2008 at 09:41:12AM +0100, Daniel P. Berrange wrote: On Thu, Aug 21, 2008 at 08:35:25AM +0200, Daniel Veillard wrote: To make it thread-safe we'll need to add a real virGetThreadLastError() API, which is something on my todo list - with that new apps can just call

Re: [libvirt] PATCH: Ensure errors are guarenteed reported in virConnectOpen

2008-08-21 Thread Daniel P. Berrange
On Thu, Aug 21, 2008 at 11:30:11AM +0200, Daniel Veillard wrote: On Thu, Aug 21, 2008 at 09:41:12AM +0100, Daniel P. Berrange wrote: On Thu, Aug 21, 2008 at 08:35:25AM +0200, Daniel Veillard wrote: To make it thread-safe we'll need to add a real virGetThreadLastError() API, which is

Re: [libvirt] PATCH: Ensure errors are guarenteed reported in virConnectOpen

2008-08-21 Thread Daniel P. Berrange
On Thu, Aug 21, 2008 at 10:42:51AM +0100, Daniel P. Berrange wrote: Well, ok so let me step back a bit because there's actually several layers to this issue... - The libvirtd is single threaded. This was reasonable at first, but some of our APIs take a long time to complete, so we need