Re: [libvirt] PATCH: Fix KVM maximum vCPU count

2008-05-14 Thread Daniel P. Berrange
On Wed, May 14, 2008 at 09:32:54AM -0400, Cole Robinson wrote: > Daniel P. Berrange wrote: > > On Wed, May 14, 2008 at 11:23:08AM +0900, Atsushi SAKAI wrote: > >> Hi, Dan > >> > >> Thank you for commenting. > >> Of course, I agree your point > >> and that you are commiting it. > >> > >> I am comme

Re: [libvirt] PATCH: Fix KVM maximum vCPU count

2008-05-14 Thread Cole Robinson
Daniel P. Berrange wrote: > On Wed, May 14, 2008 at 11:23:08AM +0900, Atsushi SAKAI wrote: >> Hi, Dan >> >> Thank you for commenting. >> Of course, I agree your point >> and that you are commiting it. >> >> I am commenting it >> just because 2 month is not old ago in my feeling. >> >> >> Here Is

Re: [libvirt] PATCH: Fix KVM maximum vCPU count

2008-05-13 Thread Daniel P. Berrange
On Wed, May 14, 2008 at 11:23:08AM +0900, Atsushi SAKAI wrote: > Hi, Dan > > Thank you for commenting. > Of course, I agree your point > and that you are commiting it. > > I am commenting it > just because 2 month is not old ago in my feeling. > > > Here Is the memo for my understanding. > (S

Re: [libvirt] PATCH: Fix KVM maximum vCPU count

2008-05-13 Thread Atsushi SAKAI
Hi, Dan Thank you for commenting. Of course, I agree your point and that you are commiting it. I am commenting it just because 2 month is not old ago in my feeling. Here Is the memo for my understanding. (Since I am not familiar with KVM) 2007/07/19 kvm-30 Guest SMP support (Parameter(KV

Re: [libvirt] PATCH: Fix KVM maximum vCPU count

2008-05-13 Thread Cole Robinson
Daniel P. Berrange wrote: > On Tue, May 13, 2008 at 01:29:35PM +0900, Atsushi SAKAI wrote: >> Hi, Dan >> >> I think the qemu_driver should check KVM_API_VERSION for SMP support. >> How do you think? >> I am worrying about MAX_VCPUS=16 changes to 32 in future. > > If it increases to 32, then we sho

Re: [libvirt] PATCH: Fix KVM maximum vCPU count

2008-05-13 Thread Daniel P. Berrange
On Tue, May 13, 2008 at 01:29:35PM +0900, Atsushi SAKAI wrote: > Hi, Dan > > I think the qemu_driver should check KVM_API_VERSION for SMP support. > How do you think? > I am worrying about MAX_VCPUS=16 changes to 32 in future. If it increases to 32, then we should certainly check based on somethi

Re: [libvirt] PATCH: Fix KVM maximum vCPU count

2008-05-12 Thread Atsushi SAKAI
Hi, Dan I think the qemu_driver should check KVM_API_VERSION for SMP support. How do you think? I am worrying about MAX_VCPUS=16 changes to 32 in future. Thanks Atsushi SAKAI "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > I don't bother trying to detect old versions of KVM which are UP only

[libvirt] PATCH: Fix KVM maximum vCPU count

2008-05-12 Thread Daniel P. Berrange
Libvirt currently returns '1' when asked for the maximum number of VCPUs supported for KVM guests. KVM long long ago gained SMP support, so this patch fixes it to return 16, whcih is the current supported number. I don't bother trying to detect old versions of KVM which are UP only because I find