Re: [libvirt] PATCH: Latest MinGW patches

2008-09-12 Thread atif bajwa
Hi, I have seen the fixes for MinGW have been included to 0.4.5 release. But I am unable to find the windows binaries on the site, which were to be generated using MinGW. If anyone of you already have client binaries for windows, please share them with me. SAKAI already shared me link to build

Re: [libvirt] PATCH: Latest MinGW patches

2008-09-12 Thread Richard W.M. Jones
On Fri, Sep 12, 2008 at 08:35:12AM +0100, atif bajwa wrote: I have seen the fixes for MinGW have been included to 0.4.5 release. But I am unable to find the windows binaries on the site, which were to be generated using MinGW. If anyone of you already have client binaries for windows, please

Re: [libvirt] PATCH: Latest MinGW patches

2008-09-04 Thread Jim Meyering
Daniel P. Berrange [EMAIL PROTECTED] wrote: On Wed, Sep 03, 2008 at 01:35:27PM +0100, Daniel P. Berrange wrote: I've got a MinGW build environment setup on Fedora 10 now, so just checked out what the latest state of libvirt CVS is. ... This new version of the patch fixes two small bugs in the

Re: [libvirt] PATCH: Latest MinGW patches

2008-09-04 Thread Richard W.M. Jones
Yes, this patch looks fine, and adding the MinGW build to the automatic build script is great. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones Read my OCaml programming blog: http://camltastic.blogspot.com/ Fedora now supports 67 OCaml packages (the OPEN

Re: [libvirt] PATCH: Latest MinGW patches

2008-09-04 Thread Richard W.M. Jones
On Thu, Sep 04, 2008 at 08:24:14AM +0200, Jim Meyering wrote: Instead of adding the #if/else blocks above, how about adding these in some header file? #ifndef HAVE_GETGID static inline gid_t getgid (void) { return 0; } #endif #ifndef HAVE_GETUID static inline uid_t getuid (void) {

Re: [libvirt] PATCH: Latest MinGW patches

2008-09-04 Thread atif bajwa
Just wondering, Will it help to solve issues with libvirt windows port or list of items mentioned at http://wiki.libvirt.org/page/TodoWindowsSupport. Regards, Atif On Thu, Sep 4, 2008 at 11:30 AM, Richard W.M. Jones [EMAIL PROTECTED]wrote: Yes, this patch looks fine, and adding the MinGW build

Re: [libvirt] PATCH: Latest MinGW patches

2008-09-04 Thread Jim Meyering
Richard W.M. Jones [EMAIL PROTECTED] wrote: On Thu, Sep 04, 2008 at 08:24:14AM +0200, Jim Meyering wrote: Instead of adding the #if/else blocks above, how about adding these in some header file? #ifndef HAVE_GETGID static inline gid_t getgid (void) { return 0; } #endif #ifndef HAVE_GETUID

Re: [libvirt] PATCH: Latest MinGW patches

2008-09-04 Thread Richard W.M. Jones
On Thu, Sep 04, 2008 at 11:42:54AM +0200, atif bajwa wrote: Just wondering, Will it help to solve issues with libvirt windows port or list of items mentioned at http://wiki.libvirt.org/page/TodoWindowsSupport. So if you follow the mailing list, you will see that Dan Berrange has just spent a

Re: [libvirt] PATCH: Latest MinGW patches

2008-09-04 Thread Richard W.M. Jones
On Thu, Sep 04, 2008 at 11:56:44AM +0200, Jim Meyering wrote: Richard W.M. Jones [EMAIL PROTECTED] wrote: On Thu, Sep 04, 2008 at 08:24:14AM +0200, Jim Meyering wrote: Instead of adding the #if/else blocks above, how about adding these in some header file? #ifndef HAVE_GETGID static

Re: [libvirt] PATCH: Latest MinGW patches

2008-09-04 Thread Daniel P. Berrange
On Thu, Sep 04, 2008 at 11:09:49AM +0100, Richard W.M. Jones wrote: On Thu, Sep 04, 2008 at 11:56:44AM +0200, Jim Meyering wrote: Richard W.M. Jones [EMAIL PROTECTED] wrote: On Thu, Sep 04, 2008 at 08:24:14AM +0200, Jim Meyering wrote: Instead of adding the #if/else blocks above, how

Re: [libvirt] PATCH: Latest MinGW patches

2008-09-04 Thread Daniel P. Berrange
On Thu, Sep 04, 2008 at 08:24:14AM +0200, Jim Meyering wrote: Daniel P. Berrange [EMAIL PROTECTED] wrote: On Wed, Sep 03, 2008 at 01:35:27PM +0100, Daniel P. Berrange wrote: I've got a MinGW build environment setup on Fedora 10 now, so just checked out what the latest state of libvirt CVS

Re: [libvirt] PATCH: Latest MinGW patches

2008-09-04 Thread Jim Meyering
Daniel P. Berrange [EMAIL PROTECTED] wrote: ... Attached is a version with that change - though I had to make it 'int' for the return type since uid_t/gid_t don't exist on mingw either. Not that it matters, since we store the result in an int anyway ... Thanks for reposting. By the light of

Re: [libvirt] PATCH: Latest MinGW patches

2008-09-04 Thread Daniel Veillard
On Wed, Sep 03, 2008 at 05:47:30PM +0100, Daniel P. Berrange wrote: On Wed, Sep 03, 2008 at 01:35:27PM +0100, Daniel P. Berrange wrote: I've got a MinGW build environment setup on Fedora 10 now, so just checked out what the latest state of libvirt CVS is. With the attached patch, I can

Re: [libvirt] PATCH: Latest MinGW patches

2008-09-04 Thread Daniel P. Berrange
On Thu, Sep 04, 2008 at 03:58:19PM +0200, Daniel Veillard wrote: On Wed, Sep 03, 2008 at 05:47:30PM +0100, Daniel P. Berrange wrote: On Wed, Sep 03, 2008 at 01:35:27PM +0100, Daniel P. Berrange wrote: I've got a MinGW build environment setup on Fedora 10 now, so just checked out what the

Re: [libvirt] PATCH: Latest MinGW patches

2008-09-04 Thread Daniel Veillard
On Thu, Sep 04, 2008 at 03:50:17PM +0100, Daniel P. Berrange wrote: On Thu, Sep 04, 2008 at 03:58:19PM +0200, Daniel Veillard wrote: On Wed, Sep 03, 2008 at 05:47:30PM +0100, Daniel P. Berrange wrote: On Wed, Sep 03, 2008 at 01:35:27PM +0100, Daniel P. Berrange wrote: I've got a MinGW