Re: [libvirt] PATCH: Pass -name argument to QEMU

2008-05-19 Thread Richard W.M. Jones
On Thu, May 15, 2008 at 10:25:24PM +0100, Daniel P. Berrange wrote: On Thu, May 15, 2008 at 09:14:12PM +0200, Gerd Hoffmann wrote: Daniel P. Berrange wrote: This patch makes libvirt pass the -name argumet to QEMU it if it supported by the QEMU binary in question. THis allows QEMU to set

Re: [libvirt] PATCH: Pass -name argument to QEMU

2008-05-16 Thread Soren Hansen
On Thu, May 15, 2008 at 10:24:35PM +0100, Daniel P. Berrange wrote: Xenner doesn't start its help output right at the start of line, Ah. :/ and there isn't any other output there that causes ambiguity in current qemu help output: # qemu-kvm | grep -- -drive -drive

Re: [libvirt] PATCH: Pass -name argument to QEMU

2008-05-15 Thread Daniel Veillard
On Tue, May 13, 2008 at 12:21:02AM +0100, Daniel P. Berrange wrote: This patch makes libvirt pass the -name argumet to QEMU it if it supported by the QEMU binary in question. THis allows QEMU to set the VNC title and allows Xenner to set the Xen guest name in xenstore. Fine by me, +1 @@

Re: [libvirt] PATCH: Pass -name argument to QEMU

2008-05-15 Thread Daniel P. Berrange
On Thu, May 15, 2008 at 10:36:18AM -0400, Daniel Veillard wrote: On Tue, May 13, 2008 at 12:21:02AM +0100, Daniel P. Berrange wrote: This patch makes libvirt pass the -name argumet to QEMU it if it supported by the QEMU binary in question. THis allows QEMU to set the VNC title and allows

Re: [libvirt] PATCH: Pass -name argument to QEMU

2008-05-15 Thread Daniel P. Berrange
On Thu, May 15, 2008 at 10:36:18AM -0400, Daniel Veillard wrote: On Tue, May 13, 2008 at 12:21:02AM +0100, Daniel P. Berrange wrote: This patch makes libvirt pass the -name argumet to QEMU it if it supported by the QEMU binary in question. THis allows QEMU to set the VNC title and allows

Re: [libvirt] PATCH: Pass -name argument to QEMU

2008-05-15 Thread Soren Hansen
On Tue, May 13, 2008 at 12:21:02AM +0100, Daniel P. Berrange wrote: -if (strstr(help, \n-drive)) -*flags |= QEMUD_CMD_FLAG_DRIVE_OPT; [...] +if (strstr(help, -drive)) +*flags |= QEMUD_CMD_FLAG_DRIVE; Why this change? I put the \n in front to prevent

Re: [libvirt] PATCH: Pass -name argument to QEMU

2008-05-15 Thread Daniel P. Berrange
On Thu, May 15, 2008 at 11:20:50PM +0200, Soren Hansen wrote: On Tue, May 13, 2008 at 12:21:02AM +0100, Daniel P. Berrange wrote: -if (strstr(help, \n-drive)) -*flags |= QEMUD_CMD_FLAG_DRIVE_OPT; [...] +if (strstr(help, -drive)) +*flags |=

Re: [libvirt] PATCH: Pass -name argument to QEMU

2008-05-15 Thread Daniel P. Berrange
On Thu, May 15, 2008 at 09:14:12PM +0200, Gerd Hoffmann wrote: Daniel P. Berrange wrote: This patch makes libvirt pass the -name argumet to QEMU it if it supported by the QEMU binary in question. THis allows QEMU to set the VNC title and allows Xenner to set the Xen guest name in xenstore.

[libvirt] PATCH: Pass -name argument to QEMU

2008-05-12 Thread Daniel P. Berrange
This patch makes libvirt pass the -name argumet to QEMU it if it supported by the QEMU binary in question. THis allows QEMU to set the VNC title and allows Xenner to set the Xen guest name in xenstore. src/qemu_conf.c | 19 ++- src/qemu_conf.h