Re: [libvirt] PATCH] Stop double free

2009-09-29 Thread Daniel Veillard
On Mon, Sep 28, 2009 at 04:30:06PM -0600, Jim Fehlig wrote: > Chris Lalancette wrote: > > While your patch would fix the problem, I'm not sure it's a good long-term > > solution. Other differences might come up in the future, and trying to > > worry > > about vshDeinit being re-entrant is probabl

Re: [libvirt] PATCH] Stop double free

2009-09-25 Thread Chris Lalancette
Mark Hamzy wrote: > The stack trace is as follows: > > Program received signal SIGABRT, Aborted. > 0x0035ad830265 in raise () from /lib64/libc.so.6 > (gdb) bt > #0 0x0035ad830265 in raise () from /lib64/libc.so.6 > #1 0x0035ad831d10 in abort () from /lib64/libc.so.6 > #2 0x0035ad86

Re: [libvirt] PATCH] Stop double free

2009-09-24 Thread Mark Hamzy
AMlibvir-list@redhat.com Subject Re: [libvirt] PATCH] Stop double

Re: [libvirt] PATCH] Stop double free

2009-09-16 Thread Chris Lalancette
Mark Hamzy wrote: > diff --git a/src/virsh.c b/src/virsh.c > index 4825f1c..5fc6c8f 100644 > --- a/src/virsh.c > +++ b/src/virsh.c > @@ -8201,7 +8201,7 @@ vshError(vshControl *ctl, int doexit, const char > *format, ...) > fputc('\n', stderr); > > if (doexit) { > - if (ctl) > + if (ctl && ctl->conn

[libvirt] PATCH] Stop double free

2009-09-15 Thread Mark Hamzy
This prevents a the following trap. Program received signal SIGABRT, Aborted. 0x0035ad830265 in raise () from /lib64/libc.so.6 (gdb) bt #0 0x0035ad830265 in raise () from /lib64/libc.so.6 #1 0x0035ad831d10 in abort () from /lib64/libc.so.6 #2 0x0035ad86a84b in __libc_message ()