Re: [libvirt] PATCH 2/4: AppArmor updates

2010-09-23 Thread Eric Blake
On 09/23/2010 09:08 AM, Daniel P. Berrange wrote: On Mon, Aug 16, 2010 at 02:33:01PM -0500, Jamie Strandboge wrote: Hrmm. I always did it this. Maybe something changed and I missed it. Regardless, thanks for this feedback! :) Attached is an updated patch. ACK Pushed as-is. That leaves 3/4

Re: [libvirt] PATCH 2/4: AppArmor updates

2010-09-23 Thread Daniel P. Berrange
On Mon, Aug 16, 2010 at 02:33:01PM -0500, Jamie Strandboge wrote: > On Mon, 2010-08-16 at 17:14 +0100, Daniel P. Berrange wrote: > > > You can't blindly de-reference data.file.path - The 'file' struct > > is inside a union and is only valid for certain types of character > > device VIR_DOMAIN_

Re: [libvirt] PATCH 2/4: AppArmor updates

2010-08-16 Thread Jamie Strandboge
On Mon, 2010-08-16 at 14:33 -0500, Jamie Strandboge wrote: > On Mon, 2010-08-16 at 17:14 +0100, Daniel P. Berrange wrote: > > > You can't blindly de-reference data.file.path - The 'file' struct > > is inside a union and is only valid for certain types of character > > device VIR_DOMAIN_CHR_TYP

Re: [libvirt] PATCH 2/4: AppArmor updates

2010-08-16 Thread Jamie Strandboge
On Mon, 2010-08-16 at 17:14 +0100, Daniel P. Berrange wrote: > You can't blindly de-reference data.file.path - The 'file' struct > is inside a union and is only valid for certain types of character > device VIR_DOMAIN_CHR_TYPE_PTY, TYPE_DEV, TYPE_FILE and TYPE_PIPE. > The existing code for ser

Re: [libvirt] PATCH 2/4: AppArmor updates

2010-08-16 Thread Daniel P. Berrange
On Fri, Aug 13, 2010 at 04:59:30PM -0500, Jamie Strandboge wrote: > Attached is 0002-apparmor-chardev.patch > > -- > Jamie Strandboge | http://www.canonical.com > Author: Jamie Strandboge > Description: fix serial ports, parallel ports and channels > Forwarded: yes > Bug-Ubuntu: LP:

[libvirt] PATCH 2/4: AppArmor updates

2010-08-13 Thread Jamie Strandboge
Attached is 0002-apparmor-chardev.patch -- Jamie Strandboge | http://www.canonical.com Author: Jamie Strandboge Description: fix serial ports, parallel ports and channels Forwarded: yes Bug-Ubuntu: LP: #578527, LP: #609055 Index: libvirt-0.8.3/src/security/virt-aa-helper.c =

Re: [libvirt] [PATCH 2/4] AppArmor updates

2009-11-12 Thread Jamie Strandboge
On Thu, 12 Nov 2009, Jamie Strandboge wrote: > 2_aa_require_absolute_path.patch: > Require absolute path for dynamic added files. This is required by > AppArmor and conveniently prevents adding tcp consoles to the profile. > This fixes https://launchpad.net/bugs/460271. > -- Jamie Strandboge