Re: [libvirt] Patch replaces scriptlets with new systemd macros

2012-11-05 Thread Eric Blake
On 10/30/2012 05:56 AM, Daniel P. Berrange wrote: Then why are we explicitly starting cgconfig.service in the spec file? Shouldn't the argument go that only those people customizing the service file to use cgconfig need cgconfig enabled in the first place? In other words, is there anything

Re: [libvirt] Patch replaces scriptlets with new systemd macros

2012-11-05 Thread Eric Blake
On 10/25/2012 04:10 AM, Václav Pavlín wrote: Hi, sorry, I didn't realize I have to modify upstream version. No problem - we'll get it all straightened out. I added Requires stanza to libvirtd service file for cgconfig.service, so you should not need to call enable in spec file for it.

Re: [libvirt] Patch replaces scriptlets with new systemd macros

2012-10-30 Thread Daniel P. Berrange
On Mon, Oct 29, 2012 at 02:53:31PM -0600, Eric Blake wrote: On 10/29/2012 05:56 AM, Daniel P. Berrange wrote: On Fri, Oct 26, 2012 at 08:09:54AM +0200, Václav Pavlín wrote: Eric Blake píše v Čt 25. 10. 2012 v 10:41 -0600: Hello, Ah, then maybe you did answer the big question. Except

Re: [libvirt] Patch replaces scriptlets with new systemd macros

2012-10-29 Thread Daniel P. Berrange
On Fri, Oct 26, 2012 at 08:09:54AM +0200, Václav Pavlín wrote: Eric Blake píše v Čt 25. 10. 2012 v 10:41 -0600: Hello, Ah, then maybe you did answer the big question. Except that I don't see the updated patch - did you forget to attach it? Sure, I did forgot, sorry. Here it is...

Re: [libvirt] Patch replaces scriptlets with new systemd macros

2012-10-29 Thread Eric Blake
On 10/29/2012 05:56 AM, Daniel P. Berrange wrote: On Fri, Oct 26, 2012 at 08:09:54AM +0200, Václav Pavlín wrote: Eric Blake píše v Čt 25. 10. 2012 v 10:41 -0600: Hello, Ah, then maybe you did answer the big question. Except that I don't see the updated patch - did you forget to attach it?

Re: [libvirt] Patch replaces scriptlets with new systemd macros

2012-10-26 Thread Václav Pavlín
Eric Blake píše v Čt 25. 10. 2012 v 10:41 -0600: Hello, Ah, then maybe you did answer the big question. Except that I don't see the updated patch - did you forget to attach it? Sure, I did forgot, sorry. Here it is... diff --git a/daemon/libvirtd.service.in b/daemon/libvirtd.service.in

Re: [libvirt] Patch replaces scriptlets with new systemd macros

2012-10-25 Thread Václav Pavlín
Hi, sorry, I didn't realize I have to modify upstream version. I added Requires stanza to libvirtd service file for cgconfig.service, so you should not need to call enable in spec file for it. I added %with_systemd_macros so it should now work in F17 with old scriptlets and in F18+/RHEL7+ with

Re: [libvirt] Patch replaces scriptlets with new systemd macros

2012-10-25 Thread Eric Blake
On 10/25/2012 04:10 AM, Václav Pavlín wrote: Hi, Hello, [please don't top-post on technical lists] sorry, I didn't realize I have to modify upstream version. No problem; we can probably figure out how to modify the upstream version based on your patch to downstream, if it comes to that,

Re: [libvirt] Patch replaces scriptlets with new systemd macros

2012-10-24 Thread Daniel P. Berrange
On Wed, Oct 24, 2012 at 12:37:51PM +0200, Václav Pavlín wrote: Hi, I created patch for spec file to follow changes in guidelines with respect to new systemd macros (see https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd) What Fedora release are these macros available since ?

Re: [libvirt] Patch replaces scriptlets with new systemd macros

2012-10-24 Thread Eric Blake
On 10/24/2012 08:29 AM, Daniel P. Berrange wrote: On Wed, Oct 24, 2012 at 12:37:51PM +0200, Václav Pavlín wrote: Hi, I created patch for spec file to follow changes in guidelines with respect to new systemd macros (see https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd)

Re: [libvirt] Patch replaces scriptlets with new systemd macros

2012-10-24 Thread Eric Blake
On 10/24/2012 04:37 AM, Václav Pavlín wrote: Hi, I created patch for spec file to follow changes in guidelines with respect to new systemd macros (see https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd) new-systemd-macros.patch diff --git a/libvirt.spec

Re: [libvirt] Patch replaces scriptlets with new systemd macros

2012-10-24 Thread Laine Stump
On 10/24/2012 01:16 PM, Eric Blake wrote: On 10/24/2012 08:29 AM, Daniel P. Berrange wrote: On Wed, Oct 24, 2012 at 12:37:51PM +0200, Václav Pavlín wrote: Hi, I created patch for spec file to follow changes in guidelines with respect to new systemd macros (see