Re: [libvirt] RFC: Introduce API to return configuration/state paths of the network driver

2013-08-18 Thread Osier Yang
On 15/08/13 19:32, Daniel P. Berrange wrote: On Wed, Aug 14, 2013 at 04:57:51AM +0530, Nehal J. Wani wrote: On Wed, Aug 14, 2013 at 4:29 AM, Eric Blake ebl...@redhat.com wrote: On 08/13/2013 04:48 PM, Eric Blake wrote: virNetworkGetDHCPLeaseForMAC(virNetworkPtr network,

Re: [libvirt] RFC: Introduce API to return configuration/state paths of the network driver

2013-08-15 Thread Daniel P. Berrange
On Wed, Aug 14, 2013 at 04:57:51AM +0530, Nehal J. Wani wrote: On Wed, Aug 14, 2013 at 4:29 AM, Eric Blake ebl...@redhat.com wrote: On 08/13/2013 04:48 PM, Eric Blake wrote: virNetworkGetDHCPLeaseForMAC(virNetworkPtr network, unsigned char *macaddr,

Re: [libvirt] RFC: Introduce API to return configuration/state paths of the network driver

2013-08-13 Thread Eric Blake
On 07/25/2013 03:35 AM, Daniel P. Berrange wrote: NACK, As I explained on IRC, the hypervisor drivers have no business accessing the dnsmasq lease files from the bridge driver. This is considered to be a private implementation detail. At a conceptual level, what you're after here is a

Re: [libvirt] RFC: Introduce API to return configuration/state paths of the network driver

2013-08-13 Thread Eric Blake
On 08/13/2013 04:48 PM, Eric Blake wrote: virNetworkGetDHCPLeaseForMAC(virNetworkPtr network, unsigned char *macaddr, I personally think the public API should stick to stringized representations. Yes, it's less friendly to machine code, but internally,

Re: [libvirt] RFC: Introduce API to return configuration/state paths of the network driver

2013-08-13 Thread Nehal J. Wani
On Wed, Aug 14, 2013 at 4:29 AM, Eric Blake ebl...@redhat.com wrote: On 08/13/2013 04:48 PM, Eric Blake wrote: virNetworkGetDHCPLeaseForMAC(virNetworkPtr network, unsigned char *macaddr, I personally think the public API should stick to stringized

[libvirt] RFC: Introduce API to return configuration/state paths of the network driver

2013-07-25 Thread Nehal J. Wani
Currently, there is no API which returns configuration/state paths of the network driver. Although it is a private implementation of the network driver, I don't see any harm in making the locations public because although the locations might change, there will always be a location for these files.

Re: [libvirt] RFC: Introduce API to return configuration/state paths of the network driver

2013-07-25 Thread Daniel P. Berrange
On Thu, Jul 25, 2013 at 02:02:36PM +0530, Nehal J. Wani wrote: Currently, there is no API which returns configuration/state paths of the network driver. Although it is a private implementation of the network driver, I don't see any harm in making the locations public because although the

Re: [libvirt] RFC: Introduce API to return configuration/state paths of the network driver

2013-07-25 Thread Osier Yang
On 25/07/13 17:35, Daniel P. Berrange wrote: On Thu, Jul 25, 2013 at 02:02:36PM +0530, Nehal J. Wani wrote: Currently, there is no API which returns configuration/state paths of the network driver. Although it is a private implementation of the network driver, I don't see any harm in making the

Re: [libvirt] RFC: Introduce API to return configuration/state paths of the network driver

2013-07-25 Thread Daniel P. Berrange
On Thu, Jul 25, 2013 at 06:43:00PM +0800, Osier Yang wrote: On 25/07/13 17:35, Daniel P. Berrange wrote: On Thu, Jul 25, 2013 at 02:02:36PM +0530, Nehal J. Wani wrote: Currently, there is no API which returns configuration/state paths of the network driver. Although it is a private

Re: [libvirt] RFC: Introduce API to return configuration/state paths of the network driver

2013-07-25 Thread Osier Yang
On 25/07/13 18:53, Daniel P. Berrange wrote: On Thu, Jul 25, 2013 at 06:43:00PM +0800, Osier Yang wrote: On 25/07/13 17:35, Daniel P. Berrange wrote: On Thu, Jul 25, 2013 at 02:02:36PM +0530, Nehal J. Wani wrote: Currently, there is no API which returns configuration/state paths of the

Re: [libvirt] RFC: Introduce API to return configuration/state paths of the network driver

2013-07-25 Thread Daniel P. Berrange
On Thu, Jul 25, 2013 at 07:01:05PM +0800, Osier Yang wrote: On 25/07/13 18:53, Daniel P. Berrange wrote: On Thu, Jul 25, 2013 at 06:43:00PM +0800, Osier Yang wrote: On 25/07/13 17:35, Daniel P. Berrange wrote: On Thu, Jul 25, 2013 at 02:02:36PM +0530, Nehal J. Wani wrote: Currently, there is

Re: [libvirt] RFC: Introduce API to return configuration/state paths of the network driver

2013-07-25 Thread Osier Yang
On 25/07/13 19:13, Daniel P. Berrange wrote: On Thu, Jul 25, 2013 at 07:01:05PM +0800, Osier Yang wrote: On 25/07/13 18:53, Daniel P. Berrange wrote: On Thu, Jul 25, 2013 at 06:43:00PM +0800, Osier Yang wrote: On 25/07/13 17:35, Daniel P. Berrange wrote: On Thu, Jul 25, 2013 at 02:02:36PM

Re: [libvirt] RFC: Introduce API to return configuration/state paths of the network driver

2013-07-25 Thread Osier Yang
On 25/07/13 19:21, Osier Yang wrote: On 25/07/13 19:13, Daniel P. Berrange wrote: On Thu, Jul 25, 2013 at 07:01:05PM +0800, Osier Yang wrote: On 25/07/13 18:53, Daniel P. Berrange wrote: On Thu, Jul 25, 2013 at 06:43:00PM +0800, Osier Yang wrote: On 25/07/13 17:35, Daniel P. Berrange wrote:

Re: [libvirt] RFC: Introduce API to return configuration/state paths of the network driver

2013-07-25 Thread Daniel P. Berrange
On Thu, Jul 25, 2013 at 07:37:22PM +0800, Osier Yang wrote: On 25/07/13 19:21, Osier Yang wrote: On 25/07/13 19:13, Daniel P. Berrange wrote: On Thu, Jul 25, 2013 at 07:01:05PM +0800, Osier Yang wrote: On 25/07/13 18:53, Daniel P. Berrange wrote: On Thu, Jul 25, 2013 at 06:43:00PM +0800,