Re: [libvirt] RFC: should we mandate use of VPATH builds ?

2018-02-22 Thread Viktor Mihajlovski
On 22.02.2018 14:29, Daniel P. Berrangé wrote: > One of the things we (well I) constantly screw up is VPATH builds. I've > always tended to just build in the source tree, and as a result I'll > often miss changes which break VPATH builds. > > Now our Jenkins CI catches this because it does VPATH b

Re: [libvirt] RFC: should we mandate use of VPATH builds ?

2018-02-22 Thread Jaroslav Suchanek
On Thu, Feb 22, 2018 at 01:29:35PM +, Daniel P. Berrangé wrote: > One of the things we (well I) constantly screw up is VPATH builds. I've > always tended to just build in the source tree, and as a result I'll > often miss changes which break VPATH builds. > > Now our Jenkins CI catches this be

Re: [libvirt] RFC: should we mandate use of VPATH builds ?

2018-02-22 Thread Jiri Denemark
On Thu, Feb 22, 2018 at 13:29:35 +, Daniel P. Berrangé wrote: > One of the things we (well I) constantly screw up is VPATH builds. I've > always tended to just build in the source tree, and as a result I'll > often miss changes which break VPATH builds. > > Now our Jenkins CI catches this beca

Re: [libvirt] RFC: should we mandate use of VPATH builds ?

2018-02-22 Thread Peter Krempa
On Thu, Feb 22, 2018 at 13:29:35 +, Daniel Berrange wrote: > One of the things we (well I) constantly screw up is VPATH builds. I've > always tended to just build in the source tree, and as a result I'll > often miss changes which break VPATH builds. I vote for _no_. I mostly use in-tree build

[libvirt] RFC: should we mandate use of VPATH builds ?

2018-02-22 Thread Daniel P . Berrangé
One of the things we (well I) constantly screw up is VPATH builds. I've always tended to just build in the source tree, and as a result I'll often miss changes which break VPATH builds. Now our Jenkins CI catches this because it does VPATH builds only, so we don't bit-rot for very long. Unfortuna