"Richard W.M. Jones" <[EMAIL PROTECTED]> wrote:
> OK how about this one ...
Nice!
Where you changed/added things, I prefer your wording.
ACK
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
OK how about this one ...
Rich.
--
Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top
? scripts/Makef
"Richard W.M. Jones" <[EMAIL PROTECTED]> wrote:
> Suggested patch attached.
Looks fine. Now that you've added the format string
argument, we can give diagnostics that are more useful not
just to users, but also to those who end up debugging things.
> It seems a little bit perverse to have to put
"Richard W.M. Jones" <[EMAIL PROTECTED]> wrote:
...
> It seems a little bit perverse to have to put gettext around
> "%s: %s" but that's what make syntax-check wants.
That is a relatively naive rule that was good enough for the existing uses.
It shouldn't be hard to make it grant exceptions like t
On Fri, Jun 06, 2008 at 05:01:20PM +0200, Jim Meyering wrote:
> "Richard W.M. Jones" <[EMAIL PROTECTED]> wrote:
> > Attached is an updated patch. The changes are:
> > - updated to latest CVS
> > - run make check / syntax-check
> > - remove virsh subcommand (as per Dan's suggestion - see below)
"Richard W.M. Jones" <[EMAIL PROTECTED]> wrote:
> Attached is an updated patch. The changes are:
> - updated to latest CVS
> - run make check / syntax-check
> - remove virsh subcommand (as per Dan's suggestion - see below)
> - some more things that Dan pointed out - see below
...
> Index: src/
On Thu, Jun 05, 2008 at 08:38:15AM -0400, Daniel Veillard wrote:
> hum, we should add a flags extra data. And based on some IRC discussion
> you already have an use for this.
Thanks - I really need this so I'll commit it, with an extra (unused)
flags parameter.
> Once you have commited the re
On Wed, Jun 04, 2008 at 04:10:32PM +0100, Richard W.M. Jones wrote:
> Attached is an updated patch. The changes are:
>
> - updated to latest CVS
> - run make check / syntax-check
> - remove virsh subcommand (as per Dan's suggestion - see below)
> - some more things that Dan pointed out - see
Attached is an updated patch. The changes are:
- updated to latest CVS
- run make check / syntax-check
- remove virsh subcommand (as per Dan's suggestion - see below)
- some more things that Dan pointed out - see below
I would like to add this to CVS because it is quite a pain tracking
CVS c