Re: [libvirt] Re: [PATCH 2/6] host (node) device enumeration - internal API additions

2008-10-28 Thread Daniel Veillard
On Tue, Oct 21, 2008 at 01:54:13PM -0400, David Lively wrote: This patch contains the internal API additions. Looks fine to me, just a couple of questions: +// TODO: Implement PCI bus devs +// TODO: Implement USB bus devs Any reason it's not in ? I would expect HAL to

Re: [libvirt] Re: [PATCH 2/6] host (node) device enumeration - internal API additions

2008-10-28 Thread Daniel Veillard
On Tue, Oct 28, 2008 at 11:32:03AM -0400, David Lively wrote: On Tue, 2008-10-28 at 14:13 +0100, Daniel Veillard wrote: On Tue, Oct 21, 2008 at 01:54:13PM -0400, David Lively wrote: This patch contains the internal API additions. Looks fine to me, just a couple of questions: +

[libvirt] Re: [PATCH 2/6] host (node) device enumeration - internal API additions

2008-10-21 Thread David Lively
This patch contains the internal API additions. diff --git a/src/hash.c b/src/hash.c index 0a5bdcd..424c4a7 100644 --- a/src/hash.c +++ b/src/hash.c @@ -687,6 +687,9 @@ virGetConnect(void) { ret-storageVols = virHashCreate(20); if (ret-storageVols == NULL) goto failed; +