[libvirt] handling qemuMonitorAddDevice failure: missing drive_del function?

2010-05-18 Thread Jim Meyering
In src/qemu/qemu_driver.c, coverity gripes (rightly) about this: 6912qemuDomainObjEnterMonitorWithDriver(driver, vm); 6913if (qemuCmdFlags QEMUD_CMD_FLAG_DEVICE) { 6914ret = qemuMonitorAddDrive(priv-mon, drivestr); 6915if (ret == 0) No check of the return value of

Re: [libvirt] handling qemuMonitorAddDevice failure: missing drive_del function?

2010-05-18 Thread Daniel P. Berrange
On Tue, May 18, 2010 at 03:23:23PM +0200, Jim Meyering wrote: In src/qemu/qemu_driver.c, coverity gripes (rightly) about this: 6912qemuDomainObjEnterMonitorWithDriver(driver, vm); 6913if (qemuCmdFlags QEMUD_CMD_FLAG_DEVICE) { 6914ret = qemuMonitorAddDrive(priv-mon,

Re: [libvirt] handling qemuMonitorAddDevice failure: missing drive_del function?

2010-05-18 Thread Jim Meyering
Daniel P. Berrange wrote: On Tue, May 18, 2010 at 03:23:23PM +0200, Jim Meyering wrote: In src/qemu/qemu_driver.c, coverity gripes (rightly) about this: 6912qemuDomainObjEnterMonitorWithDriver(driver, vm); 6913if (qemuCmdFlags QEMUD_CMD_FLAG_DEVICE) { 6914ret =

Re: [libvirt] handling qemuMonitorAddDevice failure: missing drive_del function?

2010-05-18 Thread Daniel P. Berrange
On Tue, May 18, 2010 at 04:02:44PM +0200, Jim Meyering wrote: Daniel P. Berrange wrote: On Tue, May 18, 2010 at 03:23:23PM +0200, Jim Meyering wrote: In src/qemu/qemu_driver.c, coverity gripes (rightly) about this: 6912qemuDomainObjEnterMonitorWithDriver(driver, vm); 6913if