Re: [libvirt] libvirt-java storage support and refactoring

2008-08-05 Thread Tóth István
Daniel Veillard wrote: > On Mon, Aug 04, 2008 at 11:59:38PM +0200, Toth Istvan wrote: > >> Here's a new take on the patch (It's against current CVS) >> >> The changes from the previous patch: >> >> - I've changed the generic functions to macros, so now they are as >> typesafe as JNI lets them be

Re: [libvirt] libvirt-java storage support and refactoring

2008-08-05 Thread Daniel Veillard
On Mon, Aug 04, 2008 at 11:59:38PM +0200, Toth Istvan wrote: > Here's a new take on the patch (It's against current CVS) > > The changes from the previous patch: > > - I've changed the generic functions to macros, so now they are as > typesafe as JNI lets them be. > > - I've converted all applic

Re: [libvirt] libvirt-java storage support and refactoring

2008-08-04 Thread Richard W.M. Jones
On Sat, Aug 02, 2008 at 06:39:44PM +0200, Chris Lalancette wrote: > Tóth István wrote: > > I've found that libvirt for the most part has a very perdicitble and > > repetitive API (great design!), and as a result I've found myself > > copying the same code over and over again. > > I've decided t

Re: [libvirt] libvirt-java storage support and refactoring

2008-08-03 Thread Daniel Veillard
On Mon, Aug 04, 2008 at 07:46:05AM +0200, Toth Istvan wrote: > On Sun, 2008-08-03 at 05:56 -0400, Daniel Veillard wrote: > > How is it smaller code ? > > Actually, that's not the new-style code, It's just the bugfixed one. I > have not converted that file yet. heh, okay :-) > To see the new

Re: [libvirt] libvirt-java storage support and refactoring

2008-08-03 Thread Toth Istvan
On Sun, 2008-08-03 at 05:56 -0400, Daniel Veillard wrote: > On Sat, Aug 02, 2008 at 05:42:36PM +0200, Tóth István wrote: > > Hello! > > Welcome back :-) > > > This patch contains the following: > > > > - The complete storage handling API > > - Fixing memory leaks in the VirConnect JNI impleme

Re: [libvirt] libvirt-java storage support and refactoring

2008-08-03 Thread Daniel Veillard
On Sat, Aug 02, 2008 at 05:42:36PM +0200, Tóth István wrote: > Hello! Welcome back :-) > This patch contains the following: > > - The complete storage handling API > - Fixing memory leaks in the VirConnect JNI implementation Very cool ! > I've written the new classes using a new approach.

Re: [libvirt] libvirt-java storage support and refactoring

2008-08-02 Thread Chris Lalancette
Tóth István wrote: > I've found that libvirt for the most part has a very perdicitble and > repetitive API (great design!), and as a result I've found myself > copying the same code over and over again. > I've decided to make generic JNI functions, that can handle multiple > libvirt functions

[libvirt] libvirt-java storage support and refactoring

2008-08-02 Thread Tóth István
Hello! This patch contains the following: - The complete storage handling API - Fixing memory leaks in the VirConnect JNI implementation I've written the new classes using a new approach. I've found that libvirt for the most part has a very perdicitble and repetitive API (great design!), and