Re: [libvirt-python PATCH v2 2/3] gitlab: introduce CI jobs testing git master & distro libvirt

2020-05-01 Thread Daniel P . Berrangé
On Thu, Apr 30, 2020 at 07:19:07PM +0200, Andrea Bolognani wrote: > On Thu, 2020-04-30 at 15:14 +0100, Daniel P. Berrangé wrote: > > +++ b/.gitlab-ci.yml > > @@ -0,0 +1,171 @@ > > + > > +stages: > > + - prebuild > > + - containers > > + - build > > Should this stage be called "builds", just lik

Re: [libvirt-python PATCH v2 2/3] gitlab: introduce CI jobs testing git master & distro libvirt

2020-04-30 Thread Andrea Bolognani
On Thu, 2020-04-30 at 15:14 +0100, Daniel P. Berrangé wrote: > +++ b/.gitlab-ci.yml > @@ -0,0 +1,171 @@ > + > +stages: > + - prebuild > + - containers > + - build Should this stage be called "builds", just like the previous one is called "containers"? I'm also thinking whether it would be inte

Re: [libvirt-python PATCH v2 2/3] gitlab: introduce CI jobs testing git master & distro libvirt

2020-04-30 Thread Daniel P . Berrangé
On Thu, Apr 30, 2020 at 03:14:15PM +0100, Daniel P. Berrangé wrote: > The python build needs to validate two axis > > - A variety of libvirt versions > - A variety of python versions > > We get coverage for both these axis by running a build against the > distro provided libvirt packages. All t

[libvirt-python PATCH v2 2/3] gitlab: introduce CI jobs testing git master & distro libvirt

2020-04-30 Thread Daniel P . Berrangé
The python build needs to validate two axis - A variety of libvirt versions - A variety of python versions We get coverage for both these axis by running a build against the distro provided libvirt packages. All that is then missing is a build against the latest libvirt git master, which only n