Re: [libvirt PATCH] All pointers to virXMLPropString() use g_autofree.

2020-07-09 Thread Nicolás Brignone
Ack, Thanks! On Thu, Jul 9, 2020 at 2:48 PM Daniel P. Berrangé wrote: > > On Thu, Jul 09, 2020 at 02:40:34PM -0300, Nicolás Brignone wrote: > > On Thu, Jul 9, 2020 at 5:15 AM Daniel P. Berrangé > > wrote: > > > > > > On Wed, Jul 08, 2020 at 11:15:27PM -0400, Laine Stump wrote: > > > > On

Re: [libvirt PATCH] All pointers to virXMLPropString() use g_autofree.

2020-07-09 Thread Daniel P . Berrangé
On Thu, Jul 09, 2020 at 02:40:34PM -0300, Nicolás Brignone wrote: > On Thu, Jul 9, 2020 at 5:15 AM Daniel P. Berrangé wrote: > > > > On Wed, Jul 08, 2020 at 11:15:27PM -0400, Laine Stump wrote: > > > On 7/8/20 4:19 PM, Nicolas Brignone wrote: > > > > All pointers to virXMLPropString() use

Re: [libvirt PATCH] All pointers to virXMLPropString() use g_autofree.

2020-07-09 Thread Nicolás Brignone
On Thu, Jul 9, 2020 at 5:15 AM Daniel P. Berrangé wrote: > > On Wed, Jul 08, 2020 at 11:15:27PM -0400, Laine Stump wrote: > > On 7/8/20 4:19 PM, Nicolas Brignone wrote: > > > All pointers to virXMLPropString() use g_autofree. > > > > > > I changed the summary line like this, to be more precise:

Re: [libvirt PATCH] All pointers to virXMLPropString() use g_autofree.

2020-07-09 Thread Nicolás Brignone
On Thu, Jul 9, 2020 at 12:15 AM Laine Stump wrote: > > On 7/8/20 4:19 PM, Nicolas Brignone wrote: > > All pointers to virXMLPropString() use g_autofree. > > > I changed the summary line like this, to be more precise: > > > conf: use g_autofree for all pointers to virXMLPropString() in

Re: [libvirt PATCH] All pointers to virXMLPropString() use g_autofree.

2020-07-09 Thread Daniel P . Berrangé
On Wed, Jul 08, 2020 at 11:15:27PM -0400, Laine Stump wrote: > On 7/8/20 4:19 PM, Nicolas Brignone wrote: > > All pointers to virXMLPropString() use g_autofree. > > > I changed the summary line like this, to be more precise: > > > conf: use g_autofree for all pointers to virXMLPropString()

Re: [libvirt PATCH] All pointers to virXMLPropString() use g_autofree.

2020-07-08 Thread Laine Stump
On 7/8/20 4:19 PM, Nicolas Brignone wrote: All pointers to virXMLPropString() use g_autofree. I changed the summary line like this, to be more precise: conf: use g_autofree for all pointers to virXMLPropString() in device_conf.c All modified functions are similar, in all cases

[libvirt PATCH] All pointers to virXMLPropString() use g_autofree.

2020-07-08 Thread Nicolas Brignone
All modified functions are similar, in all cases "cleanup" label is removed, along with all the "goto" calls. Signed-off-by: Nicolas Brignone --- src/conf/device_conf.c | 183 + 1 file changed, 56 insertions(+), 127 deletions(-) diff --git