Re: [libvirt PATCH] drivers: Group global feature together

2022-04-07 Thread Andrea Bolognani
On Thu, Apr 07, 2022 at 02:24:05PM +0200, Ján Tomko wrote: > On a Thursday in 2022, Andrea Bolognani wrote: > > On Wed, Feb 16, 2022 at 09:26:21PM +0100, Ján Tomko wrote: > > > > switch ((virDrvFeature) feature) { > > > > +case VIR_DRV_FEATURE_REMOTE: > > > > +case

Re: [libvirt PATCH] drivers: Group global feature together

2022-04-07 Thread Ján Tomko
On a Thursday in 2022, Andrea Bolognani wrote: On Wed, Feb 16, 2022 at 09:26:21PM +0100, Ján Tomko wrote: > switch ((virDrvFeature) feature) { > +case VIR_DRV_FEATURE_REMOTE: > +case VIR_DRV_FEATURE_PROGRAM_KEEPALIVE: > +case VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK: >

Re: [libvirt PATCH] drivers: Group global feature together

2022-02-17 Thread Andrea Bolognani
On Wed, Feb 16, 2022 at 09:26:21PM +0100, Ján Tomko wrote: > > switch ((virDrvFeature) feature) { > > +case VIR_DRV_FEATURE_REMOTE: > > +case VIR_DRV_FEATURE_PROGRAM_KEEPALIVE: > > +case VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK: > > +case

Re: [libvirt PATCH] drivers: Group global feature together

2022-02-16 Thread Ján Tomko
s/feature/features/ On a Wednesday in 2022, Andrea Bolognani wrote: All these features are supposed to be handled by the call to virDriverFeatureIsGlobal() placed right above the switch statement, so group them together and add a comment. If any of these features is actually encountered as part

[libvirt PATCH] drivers: Group global feature together

2022-02-16 Thread Andrea Bolognani
All these features are supposed to be handled by the call to virDriverFeatureIsGlobal() placed right above the switch statement, so group them together and add a comment. If any of these features is actually encountered as part of the switch statements, that means there's a bug in the driver and