Re: [libvirt PATCH] meson: add -Wall and -Wextra explicitly for buildtype=plain

2020-09-02 Thread Daniel P . Berrangé
On Tue, Sep 01, 2020 at 04:08:04PM +0200, Pavel Hrdina wrote: > If someone runs `meson setup --buildtype plain` meson ignores > warning_level=2 that is in our meson.build file. The implication is > that Meson will not automatically add -Wall which enables -Wformat. > > This breaks building

Re: [libvirt PATCH] meson: add -Wall and -Wextra explicitly for buildtype=plain

2020-09-02 Thread Pavel Hrdina
On Tue, Sep 01, 2020 at 04:37:06PM -0600, Jim Fehlig wrote: > On 9/1/20 8:08 AM, Pavel Hrdina wrote: > > If someone runs `meson setup --buildtype plain` meson ignores > > warning_level=2 that is in our meson.build file. The implication is > > that Meson will not automatically add -Wall which

Re: [libvirt PATCH] meson: add -Wall and -Wextra explicitly for buildtype=plain

2020-09-01 Thread Jim Fehlig
On 9/1/20 8:08 AM, Pavel Hrdina wrote: If someone runs `meson setup --buildtype plain` meson ignores warning_level=2 that is in our meson.build file. The implication is that Meson will not automatically add -Wall which enables -Wformat. This breaks building libvirt from git with the buildtype

[libvirt PATCH] meson: add -Wall and -Wextra explicitly for buildtype=plain

2020-09-01 Thread Pavel Hrdina
If someone runs `meson setup --buildtype plain` meson ignores warning_level=2 that is in our meson.build file. The implication is that Meson will not automatically add -Wall which enables -Wformat. This breaks building libvirt from git with the buildtype set to plain. There is an issue reported