Re: [libvirt PATCH] qemu: Fix domain ID allocation

2020-02-03 Thread Daniel P . Berrangé
On Fri, Jan 31, 2020 at 04:33:50PM +0100, Michal Privoznik wrote: > On 1/31/20 3:43 PM, Ján Tomko wrote: > > The rewrite to use GLib's atomic ops functions changed the behavior > > of virAtomicIntInc - before it returned the pre-increment value. > > > > Most of the callers using its value were

Re: [libvirt PATCH] qemu: Fix domain ID allocation

2020-01-31 Thread Michal Privoznik
On 1/31/20 4:45 PM, Ján Tomko wrote: On Fri, Jan 31, 2020 at 04:33:50PM +0100, Michal Privoznik wrote: On 1/31/20 3:43 PM, Ján Tomko wrote: The rewrite to use GLib's atomic ops functions changed the behavior of virAtomicIntInc - before it returned the pre-increment value. Most of the callers

Re: [libvirt PATCH] qemu: Fix domain ID allocation

2020-01-31 Thread Ján Tomko
On Fri, Jan 31, 2020 at 04:33:50PM +0100, Michal Privoznik wrote: On 1/31/20 3:43 PM, Ján Tomko wrote: The rewrite to use GLib's atomic ops functions changed the behavior of virAtomicIntInc - before it returned the pre-increment value. Most of the callers using its value were adjusted, but the

Re: [libvirt PATCH] qemu: Fix domain ID allocation

2020-01-31 Thread Michal Privoznik
On 1/31/20 3:43 PM, Ján Tomko wrote: The rewrite to use GLib's atomic ops functions changed the behavior of virAtomicIntInc - before it returned the pre-increment value. Most of the callers using its value were adjusted, but the one in qemuDriverAllocateID was not. If libvirtd would reconnect

Re: [libvirt PATCH] qemu: Fix domain ID allocation

2020-01-31 Thread Peter Krempa
On Fri, Jan 31, 2020 at 15:43:14 +0100, Ján Tomko wrote: > The rewrite to use GLib's atomic ops functions changed the behavior > of virAtomicIntInc - before it returned the pre-increment value. > > Most of the callers using its value were adjusted, but the one > in qemuDriverAllocateID was not.

[libvirt PATCH] qemu: Fix domain ID allocation

2020-01-31 Thread Ján Tomko
The rewrite to use GLib's atomic ops functions changed the behavior of virAtomicIntInc - before it returned the pre-increment value. Most of the callers using its value were adjusted, but the one in qemuDriverAllocateID was not. If libvirtd would reconnect to a running domain during startup, the