Re: [libvirt PATCH] qemu: fix crash in qemuDomainSetBlkioParameters without cgroups

2020-08-12 Thread Ján Tomko
On a Tuesday in 2020, Pavel Hrdina wrote: If we don't have cgroups available and user tries to update blkio parameters for running VM it will crash. It should have been protected by the virCgroupHasController() check but it was never called if the API was executed without any flags. We call

[libvirt PATCH] qemu: fix crash in qemuDomainSetBlkioParameters without cgroups

2020-08-11 Thread Pavel Hrdina
If we don't have cgroups available and user tries to update blkio parameters for running VM it will crash. It should have been protected by the virCgroupHasController() check but it was never called if the API was executed without any flags. We call virDomainObjGetDefs() which sets `def` and