Re: [libvirt PATCH] qemu: honour fatal errors dealing with qemu slirp helper

2020-10-23 Thread Daniel Henrique Barboza
On 10/20/20 12:07 PM, Daniel P. Berrangé wrote: Currently all errors from qemuInterfacePrepareSlirp() are completely ignored by the callers. The intention is that missing qemu-slirp binary should cause the caller to fallback to the built-in slirp impl. Many of the possible errors though shoul

[libvirt PATCH] qemu: honour fatal errors dealing with qemu slirp helper

2020-10-20 Thread Daniel P . Berrangé
Currently all errors from qemuInterfacePrepareSlirp() are completely ignored by the callers. The intention is that missing qemu-slirp binary should cause the caller to fallback to the built-in slirp impl. Many of the possible errors though should indeed be considered fatal. Signed-off-by: Daniel