Re: [libvirt PATCH] qemu: remove unreachable code in qemuProcessStart()

2020-08-24 Thread Laine Stump
On 8/24/20 6:30 PM, Daniel Henrique Barboza wrote: On 8/23/20 1:51 AM, Laine Stump wrote: Back when the original version of this chunk of code was added (commit 41b087198 in libvirt-0.8.1 in April 2010), we used virExecDaemonize() to start the qemu process, and would continue on in the functio

Re: [libvirt PATCH] qemu: remove unreachable code in qemuProcessStart()

2020-08-24 Thread Daniel Henrique Barboza
On 8/23/20 1:51 AM, Laine Stump wrote: Back when the original version of this chunk of code was added (commit 41b087198 in libvirt-0.8.1 in April 2010), we used virExecDaemonize() to start the qemu process, and would continue on in the function (which at that time was called qemudStartVMDaemon

[libvirt PATCH] qemu: remove unreachable code in qemuProcessStart()

2020-08-22 Thread Laine Stump
Back when the original version of this chunk of code was added (commit 41b087198 in libvirt-0.8.1 in April 2010), we used virExecDaemonize() to start the qemu process, and would continue on in the function (which at that time was called qemudStartVMDaemon()) even if a -1 was returned. So it was pos