Re: [libvirt PATCH] qemu: validate VNC password length

2021-12-16 Thread Pavel Hrdina
On Thu, Dec 16, 2021 at 10:48:53AM +, Daniel P. Berrangé wrote: > The VNC password authentication scheme is quite horrendous in that it > takes the user password and directly uses it as a DES case. DES is a > byte 8 keyed cipher, so the VNC password can never be more than 8 > characters long.

[libvirt PATCH] qemu: validate VNC password length

2021-12-16 Thread Daniel P . Berrangé
The VNC password authentication scheme is quite horrendous in that it takes the user password and directly uses it as a DES case. DES is a byte 8 keyed cipher, so the VNC password can never be more than 8 characters long. Anything over that length will be silently dropped. We should validate this