Re: [libvirt PATCH] qemu_firmware: don't error out for unknown firmware features

2022-01-31 Thread Daniel P . Berrangé
On Mon, Jan 31, 2022 at 03:55:03PM +0100, Pavel Hrdina wrote: > On Mon, Jan 31, 2022 at 03:45:18PM +0100, Michal Prívozník wrote: > > On 1/31/22 15:38, Daniel P. Berrangé wrote: > > > > > > > > Oh, I hadn't checked how number prioritization affects it. So you're > > > saying that we stop parsing

Re: [libvirt PATCH] qemu_firmware: don't error out for unknown firmware features

2022-01-31 Thread Pavel Hrdina
On Mon, Jan 31, 2022 at 03:45:18PM +0100, Michal Prívozník wrote: > On 1/31/22 15:38, Daniel P. Berrangé wrote: > > > > > Oh, I hadn't checked how number prioritization affects it. So you're > > saying that we stop parsing the firmware file as soon as we find a > > valid match. That does indeed

Re: [libvirt PATCH] qemu_firmware: don't error out for unknown firmware features

2022-01-31 Thread Michal Prívozník
On 1/31/22 15:38, Daniel P. Berrangé wrote: > > Oh, I hadn't checked how number prioritization affects it. So you're > saying that we stop parsing the firmware file as soon as we find a > valid match. That does indeed limit the impact of the change. Ah, my memory is failing me. We don't do

Re: [libvirt PATCH] qemu_firmware: don't error out for unknown firmware features

2022-01-31 Thread Daniel P . Berrangé
On Mon, Jan 31, 2022 at 03:19:46PM +0100, Michal Prívozník wrote: > On 1/31/22 14:18, Daniel P. Berrangé wrote: > > On Mon, May 10, 2021 at 03:16:11PM +0200, Pavel Hrdina wrote: > >> When QEMU introduces new firmware features libvirt will fail until we > >> list that feature in our code as well

Re: [libvirt PATCH] qemu_firmware: don't error out for unknown firmware features

2022-01-31 Thread Michal Prívozník
On 1/31/22 14:18, Daniel P. Berrangé wrote: > On Mon, May 10, 2021 at 03:16:11PM +0200, Pavel Hrdina wrote: >> When QEMU introduces new firmware features libvirt will fail until we >> list that feature in our code as well which doesn't sound right. >> >> We should simply ignore the new feature

Re: [libvirt PATCH] qemu_firmware: don't error out for unknown firmware features

2022-01-31 Thread Daniel P . Berrangé
On Mon, May 10, 2021 at 03:16:11PM +0200, Pavel Hrdina wrote: > When QEMU introduces new firmware features libvirt will fail until we > list that feature in our code as well which doesn't sound right. > > We should simply ignore the new feature until we add a proper support > for it. > >

Re: [libvirt PATCH] qemu_firmware: don't error out for unknown firmware features

2021-05-10 Thread Pavel Hrdina
On Mon, May 10, 2021 at 03:24:39PM +0200, Peter Krempa wrote: > On Mon, May 10, 2021 at 15:16:11 +0200, Pavel Hrdina wrote: > > When QEMU introduces new firmware features libvirt will fail until we > > list that feature in our code as well which doesn't sound right. > > > > We should simply

Re: [libvirt PATCH] qemu_firmware: don't error out for unknown firmware features

2021-05-10 Thread Pavel Hrdina
On Mon, May 10, 2021 at 02:24:49PM +0100, Daniel P. Berrangé wrote: > On Mon, May 10, 2021 at 03:16:11PM +0200, Pavel Hrdina wrote: > > When QEMU introduces new firmware features libvirt will fail until we > > list that feature in our code as well which doesn't sound right. > > > > We should

Re: [libvirt PATCH] qemu_firmware: don't error out for unknown firmware features

2021-05-10 Thread Daniel P . Berrangé
On Mon, May 10, 2021 at 03:16:11PM +0200, Pavel Hrdina wrote: > When QEMU introduces new firmware features libvirt will fail until we > list that feature in our code as well which doesn't sound right. > > We should simply ignore the new feature until we add a proper support > for it. > >

Re: [libvirt PATCH] qemu_firmware: don't error out for unknown firmware features

2021-05-10 Thread Peter Krempa
On Mon, May 10, 2021 at 15:16:11 +0200, Pavel Hrdina wrote: > When QEMU introduces new firmware features libvirt will fail until we > list that feature in our code as well which doesn't sound right. > > We should simply ignore the new feature until we add a proper support > for it. > >

[libvirt PATCH] qemu_firmware: don't error out for unknown firmware features

2021-05-10 Thread Pavel Hrdina
When QEMU introduces new firmware features libvirt will fail until we list that feature in our code as well which doesn't sound right. We should simply ignore the new feature until we add a proper support for it. Reported-by: Laszlo Ersek Signed-off-by: Pavel Hrdina ---