Re: [libvirt PATCH] qemu_migration: Delete vDPA check

2022-07-19 Thread Laine Stump
On 7/19/22 2:38 PM, Eugenio Perez Martin wrote: On Tue, Jul 19, 2022 at 6:43 PM Laine Stump wrote: On 7/19/22 12:01 PM, Laine Stump wrote: On 7/19/22 11:09 AM, Eugenio Perez Martin wrote: On Tue, Jul 19, 2022 at 4:02 PM Laine Stump wrote: On 7/18/22 11:15 AM, Jiri Denemark wrote: On

Re: [libvirt PATCH] qemu_migration: Delete vDPA check

2022-07-19 Thread Eugenio Perez Martin
On Tue, Jul 19, 2022 at 6:43 PM Laine Stump wrote: > > On 7/19/22 12:01 PM, Laine Stump wrote: > > On 7/19/22 11:09 AM, Eugenio Perez Martin wrote: > >> On Tue, Jul 19, 2022 at 4:02 PM Laine Stump wrote: > >>> > >>> On 7/18/22 11:15 AM, Jiri Denemark wrote: > On Mon, Jul 18, 2022 at

Re: [libvirt PATCH] qemu_migration: Delete vDPA check

2022-07-19 Thread Laine Stump
On 7/19/22 12:01 PM, Laine Stump wrote: On 7/19/22 11:09 AM, Eugenio Perez Martin wrote: On Tue, Jul 19, 2022 at 4:02 PM Laine Stump wrote: On 7/18/22 11:15 AM, Jiri Denemark wrote: On Mon, Jul 18, 2022 at 10:40:56 +0200, Eugenio Perez Martin wrote: On Mon, Jul 18, 2022 at 10:25 AM Jiri

Re: [libvirt PATCH] qemu_migration: Delete vDPA check

2022-07-19 Thread Laine Stump
On 7/19/22 11:09 AM, Eugenio Perez Martin wrote: On Tue, Jul 19, 2022 at 4:02 PM Laine Stump wrote: On 7/18/22 11:15 AM, Jiri Denemark wrote: On Mon, Jul 18, 2022 at 10:40:56 +0200, Eugenio Perez Martin wrote: On Mon, Jul 18, 2022 at 10:25 AM Jiri Denemark wrote: Which in ideal case would

Re: [libvirt PATCH] qemu_migration: Delete vDPA check

2022-07-19 Thread Eugenio Perez Martin
On Tue, Jul 19, 2022 at 5:24 PM Jiri Denemark wrote: > > On Tue, Jul 19, 2022 at 17:09:29 +0200, Eugenio Perez Martin wrote: > > On Tue, Jul 19, 2022 at 4:02 PM Laine Stump wrote: > > > Actually that's been on my todo list for a long time - for any qemu that > > > supports the QMP command that

Re: [libvirt PATCH] qemu_migration: Delete vDPA check

2022-07-19 Thread Jiri Denemark
On Tue, Jul 19, 2022 at 17:09:29 +0200, Eugenio Perez Martin wrote: > On Tue, Jul 19, 2022 at 4:02 PM Laine Stump wrote: > > Actually that's been on my todo list for a long time - for any qemu that > > supports the QMP command that checks for migratability, we should be > > calling this command

Re: [libvirt PATCH] qemu_migration: Delete vDPA check

2022-07-19 Thread Eugenio Perez Martin
On Tue, Jul 19, 2022 at 4:02 PM Laine Stump wrote: > > On 7/18/22 11:15 AM, Jiri Denemark wrote: > > On Mon, Jul 18, 2022 at 10:40:56 +0200, Eugenio Perez Martin wrote: > >> On Mon, Jul 18, 2022 at 10:25 AM Jiri Denemark wrote: > >>> Which in ideal case would mean only a QMP command (such as >

Re: [libvirt PATCH] qemu_migration: Delete vDPA check

2022-07-19 Thread Laine Stump
On 7/18/22 11:15 AM, Jiri Denemark wrote: On Mon, Jul 18, 2022 at 10:40:56 +0200, Eugenio Perez Martin wrote: On Mon, Jul 18, 2022 at 10:25 AM Jiri Denemark wrote: Which in ideal case would mean only a QMP command (such as hotplugging a non-migratable device) is the only way to add migration

Re: [libvirt PATCH] qemu_migration: Delete vDPA check

2022-07-18 Thread Jiri Denemark
On Mon, Jul 18, 2022 at 10:40:56 +0200, Eugenio Perez Martin wrote: > On Mon, Jul 18, 2022 at 10:25 AM Jiri Denemark wrote: > > Which in ideal case would mean only a QMP command (such as > > hotplugging a non-migratable device) is the only way to add migration > > blocker. If this is true, than

Re: [libvirt PATCH] qemu_migration: Delete vDPA check

2022-07-18 Thread Eugenio Perez Martin
On Mon, Jul 18, 2022 at 10:25 AM Jiri Denemark wrote: > > On Fri, Jul 15, 2022 at 11:14:58 +0200, Eugenio Pérez wrote: > > Currently, the migration code denies migration as long as the VM has a > > vhost-vDPA device. > > > > While it's true that vhost-vDPA devices cannot be migrated at the

Re: [libvirt PATCH] qemu_migration: Delete vDPA check

2022-07-18 Thread Jiri Denemark
On Fri, Jul 15, 2022 at 11:14:58 +0200, Eugenio Pérez wrote: > Currently, the migration code denies migration as long as the VM has a > vhost-vDPA device. > > While it's true that vhost-vDPA devices cannot be migrated at the moment, > there are plans to be able to migrate them soon. > > Libvirt

[libvirt PATCH] qemu_migration: Delete vDPA check

2022-07-15 Thread Eugenio Pérez
Currently, the migration code denies migration as long as the VM has a vhost-vDPA device. While it's true that vhost-vDPA devices cannot be migrated at the moment, there are plans to be able to migrate them soon. Libvirt must treat it equal to vhost-kernel devices: Not all of them can be