Re: [libvirt PATCH] tests: Mock virGetUserRuntimeDirectory() for qemuhotplug

2020-05-06 Thread Andrea Bolognani
On Mon, 2020-05-04 at 18:21 +0200, Andrea Bolognani wrote: > On Mon, 2020-05-04 at 13:44 +0200, Michal Privoznik wrote: > > On 5/1/20 2:30 PM, Andrea Bolognani wrote: > > > +char * > > > +virGetUserRuntimeDirectory(void) > > > +{ > > > +return g_build_filename(g_getenv("LIBVIRT_FAKE_ROOT_DIR"),

Re: [libvirt PATCH] tests: Mock virGetUserRuntimeDirectory() for qemuhotplug

2020-05-04 Thread Daniel P . Berrangé
On Fri, May 01, 2020 at 03:22:22PM +0200, Andrea Bolognani wrote: > On Fri, 2020-05-01 at 14:09 +0100, Daniel P. Berrangé wrote: > > On Fri, May 01, 2020 at 02:30:16PM +0200, Andrea Bolognani wrote: > > > Not mocking this function results in files being created in the > > > user's home directory wh

Re: [libvirt PATCH] tests: Mock virGetUserRuntimeDirectory() for qemuhotplug

2020-05-04 Thread Andrea Bolognani
On Mon, 2020-05-04 at 13:44 +0200, Michal Privoznik wrote: > On 5/1/20 2:30 PM, Andrea Bolognani wrote: > > +char * > > +virGetUserRuntimeDirectory(void) > > +{ > > +return g_build_filename(g_getenv("LIBVIRT_FAKE_ROOT_DIR"), > > +"user-runtime-directory", NULL); > >

Re: [libvirt PATCH] tests: Mock virGetUserRuntimeDirectory() for qemuhotplug

2020-05-04 Thread Michal Privoznik
On 5/1/20 2:30 PM, Andrea Bolognani wrote: Not mocking this function results in files being created in the user's home directory when running the test and in the build failing altogether inside a constrained environment such as the one used by pbuilder: Could not initialize HostdevManager - o

Re: [libvirt PATCH] tests: Mock virGetUserRuntimeDirectory() for qemuhotplug

2020-05-01 Thread Andrea Bolognani
On Fri, 2020-05-01 at 14:09 +0100, Daniel P. Berrangé wrote: > On Fri, May 01, 2020 at 02:30:16PM +0200, Andrea Bolognani wrote: > > Not mocking this function results in files being created in the > > user's home directory when running the test and in the build > > failing altogether inside a const

Re: [libvirt PATCH] tests: Mock virGetUserRuntimeDirectory() for qemuhotplug

2020-05-01 Thread Daniel P . Berrangé
On Fri, May 01, 2020 at 02:30:16PM +0200, Andrea Bolognani wrote: > Not mocking this function results in files being created in the > user's home directory when running the test and in the build > failing altogether inside a constrained environment such as the > one used by pbuilder: What's pbuild

[libvirt PATCH] tests: Mock virGetUserRuntimeDirectory() for qemuhotplug

2020-05-01 Thread Andrea Bolognani
Not mocking this function results in files being created in the user's home directory when running the test and in the build failing altogether inside a constrained environment such as the one used by pbuilder: Could not initialize HostdevManager - operation failed: Failed to create state dir