Re: [libvirt PATCH] util: Fix getting CPU frequency on Apple Silicon

2022-02-14 Thread Andrea Bolognani
On Mon, Feb 14, 2022 at 04:59:11AM +0800, Menci wrote: > I tested the patch (applying to v7.10.0) and it works on my M1 MacBook Air. Thanks a lot for confirming! I've pushed the patch now :) -- Andrea Bolognani / Red Hat / Virtualization

Re: [libvirt PATCH] util: Fix getting CPU frequency on Apple Silicon

2022-02-13 Thread Menci
I tested the patch (applying to v7.10.0) and it works on my M1 MacBook Air. Thanks. On Sat, Feb 12, 2022 at 1:32 AM Andrea Bolognani wrote: > On Thu, Feb 10, 2022 at 10:08:42AM +0100, Andrea Bolognani wrote: > > +++ b/src/util/virhostcpu.c > > @@ -928,8 +928,14 @@ virHostCPUGetInfo(virArch

Re: [libvirt PATCH] util: Fix getting CPU frequency on Apple Silicon

2022-02-11 Thread Andrea Bolognani
On Thu, Feb 10, 2022 at 10:08:42AM +0100, Andrea Bolognani wrote: > +++ b/src/util/virhostcpu.c > @@ -928,8 +928,14 @@ virHostCPUGetInfo(virArch hostarch G_GNUC_UNUSED, > *mhz = cpu_freq; > # else > if (sysctlbyname("hw.cpufrequency", _freq, _freq_len, NULL, 0) < > 0) { > -

Re: [libvirt PATCH] util: Fix getting CPU frequency on Apple Silicon

2022-02-10 Thread Michal Prívozník
On 2/10/22 10:08, Andrea Bolognani wrote: > The hw.cpufrequency sysctl, which we use to obtain the CPU > frequency on macOS, is not available when running on Apple > Silicon, and as a consequence we currently report an error > whenever such information is requested. > > The virNodeInfo.mhz field,

[libvirt PATCH] util: Fix getting CPU frequency on Apple Silicon

2022-02-10 Thread Andrea Bolognani
The hw.cpufrequency sysctl, which we use to obtain the CPU frequency on macOS, is not available when running on Apple Silicon, and as a consequence we currently report an error whenever such information is requested. The virNodeInfo.mhz field, where the CPU frequency gets stored, is documented as