Re: [libvirt PATCH] vmx: Don't error out on missing filename for cdrom

2020-12-21 Thread Martin Kletzander
On Mon, Dec 21, 2020 at 01:09:13PM +0100, Ján Tomko wrote: On a Monday in 2020, Martin Kletzander wrote: This is perfectly valid in VMWare and the VM just boots with an empty drive. We used to just skip the whole drive before, but since we changed how we parse empty cdrom drives this now result

Re: [libvirt PATCH] vmx: Don't error out on missing filename for cdrom

2020-12-21 Thread Tim Wiederhake
On Mon, 2020-12-21 at 12:48 +0100, Martin Kletzander wrote: > This is perfectly valid in VMWare and the VM just boots with an empty > drive. We > used to just skip the whole drive before, but since we changed how we > parse > empty cdrom drives this now results in an error and the user not > being

Re: [libvirt PATCH] vmx: Don't error out on missing filename for cdrom

2020-12-21 Thread Ján Tomko
On a Monday in 2020, Martin Kletzander wrote: This is perfectly valid in VMWare and the VM just boots with an empty drive. We used to just skip the whole drive before, but since we changed how we parse empty cdrom drives this now results in an error and the user not being able to even dump the X

[libvirt PATCH] vmx: Don't error out on missing filename for cdrom

2020-12-21 Thread Martin Kletzander
This is perfectly valid in VMWare and the VM just boots with an empty drive. We used to just skip the whole drive before, but since we changed how we parse empty cdrom drives this now results in an error and the user not being able to even dump the XML. Instead of erroring out, just keep the driv