Re: [libvirt PATCH 0/8] rpm: Fix handling of systemd units

2023-07-20 Thread Andrea Bolognani
On Fri, Jul 14, 2023 at 05:20:16PM +0100, Daniel P. Berrangé wrote: > > > If we at least start the discussion, we can get feedback on whether the > > > idea is likely to gain traction, or there are other things we have > > > overlooked > > > > I can open an issue on the systemd side pointing to the

Re: [libvirt PATCH 0/8] rpm: Fix handling of systemd units

2023-07-14 Thread Daniel P . Berrangé
On Fri, Jul 14, 2023 at 08:52:15AM -0700, Andrea Bolognani wrote: > On Fri, Jul 14, 2023 at 04:28:11PM +0100, Daniel P. Berrangé wrote: > > > > IOW, I think the problem needs to be raised & addressed in context of > > > > the Fedora and systemd communities, rather than having libvirt diverge > > >

Re: [libvirt PATCH 0/8] rpm: Fix handling of systemd units

2023-07-14 Thread Andrea Bolognani
On Fri, Jul 14, 2023 at 04:28:11PM +0100, Daniel P. Berrangé wrote: > > > IOW, I think the problem needs to be raised & addressed in context of > > > the Fedora and systemd communities, rather than having libvirt diverge > > > from normal Feora packaging practice. > > > > I absolutely agree with yo

Re: [libvirt PATCH 0/8] rpm: Fix handling of systemd units

2023-07-14 Thread Daniel P . Berrangé
On Fri, Jul 14, 2023 at 08:25:57AM -0700, Andrea Bolognani wrote: > On Fri, Jul 14, 2023 at 04:02:30PM +0100, Daniel P. Berrangé wrote: > > I don't have an objection to the conceptual approach. > > > > My concern is about where the solution is applied and divergance from > > Fedora guidelines. > >

Re: [libvirt PATCH 0/8] rpm: Fix handling of systemd units

2023-07-14 Thread Andrea Bolognani
On Fri, Jul 14, 2023 at 04:02:30PM +0100, Daniel P. Berrangé wrote: > I don't have an objection to the conceptual approach. > > My concern is about where the solution is applied and divergance from > Fedora guidelines. > > The long term direction of Fedora / RPM has been to reduce the number > of s

Re: [libvirt PATCH 0/8] rpm: Fix handling of systemd units

2023-07-14 Thread Daniel P . Berrangé
On Fri, Jul 14, 2023 at 04:39:34PM +0200, Andrea Bolognani wrote: > Plus some extras I'm throwing in for free :) > > To understand why these changes are needed, see the original bug > report[1] as well as the discussion triggered by Martin's initial > attempt at addressing it[2]. > > Getting this

[libvirt PATCH 0/8] rpm: Fix handling of systemd units

2023-07-14 Thread Andrea Bolognani
Plus some extras I'm throwing in for free :) To understand why these changes are needed, see the original bug report[1] as well as the discussion triggered by Martin's initial attempt at addressing it[2]. Getting this right is quite tricky, so in order to convince myself that I'm not just going t