Re: [libvirt PATCH 06/11] udevGetIntSysfsAttr: Return -1 for missing attributes

2021-01-28 Thread Daniel P . Berrangé
On Thu, Jan 28, 2021 at 02:03:25PM +0100, Michal Privoznik wrote: > On 1/28/21 1:47 PM, Daniel P. Berrangé wrote: > > On Thu, Jan 28, 2021 at 01:18:07PM +0100, Michal Privoznik wrote: > > > On 1/28/21 11:44 AM, Peter Krempa wrote: > > > > On Thu, Jan 28, 2021 at 11:24:36 +0100, Tim Wiederhake

Re: [libvirt PATCH 06/11] udevGetIntSysfsAttr: Return -1 for missing attributes

2021-01-28 Thread Michal Privoznik
On 1/28/21 1:47 PM, Daniel P. Berrangé wrote: On Thu, Jan 28, 2021 at 01:18:07PM +0100, Michal Privoznik wrote: On 1/28/21 11:44 AM, Peter Krempa wrote: On Thu, Jan 28, 2021 at 11:24:36 +0100, Tim Wiederhake wrote: If "udevGetDeviceSysfsAttr()" returns NULL, "udevGetIntSysfsAttr" would return

Re: [libvirt PATCH 06/11] udevGetIntSysfsAttr: Return -1 for missing attributes

2021-01-28 Thread Daniel P . Berrangé
On Thu, Jan 28, 2021 at 01:18:07PM +0100, Michal Privoznik wrote: > On 1/28/21 11:44 AM, Peter Krempa wrote: > > On Thu, Jan 28, 2021 at 11:24:36 +0100, Tim Wiederhake wrote: > > > If "udevGetDeviceSysfsAttr()" returns NULL, "udevGetIntSysfsAttr" > > > would return "0", indicating success, without

Re: [libvirt PATCH 06/11] udevGetIntSysfsAttr: Return -1 for missing attributes

2021-01-28 Thread Tim Wiederhake
On Thu, 2021-01-28 at 11:44 +0100, Peter Krempa wrote: > On Thu, Jan 28, 2021 at 11:24:36 +0100, Tim Wiederhake wrote: > > If "udevGetDeviceSysfsAttr()" returns NULL, "udevGetIntSysfsAttr" > > would return "0", indicating success, without writing to "value". > > > > This was found by clang-tidy's

Re: [libvirt PATCH 06/11] udevGetIntSysfsAttr: Return -1 for missing attributes

2021-01-28 Thread Michal Privoznik
On 1/28/21 11:44 AM, Peter Krempa wrote: On Thu, Jan 28, 2021 at 11:24:36 +0100, Tim Wiederhake wrote: If "udevGetDeviceSysfsAttr()" returns NULL, "udevGetIntSysfsAttr" would return "0", indicating success, without writing to "value". This was found by clang-tidy's

Re: [libvirt PATCH 06/11] udevGetIntSysfsAttr: Return -1 for missing attributes

2021-01-28 Thread Peter Krempa
On Thu, Jan 28, 2021 at 11:24:36 +0100, Tim Wiederhake wrote: > If "udevGetDeviceSysfsAttr()" returns NULL, "udevGetIntSysfsAttr" > would return "0", indicating success, without writing to "value". > > This was found by clang-tidy's > "clang-analyzer-core.UndefinedBinaryOperatorResult" check in >

[libvirt PATCH 06/11] udevGetIntSysfsAttr: Return -1 for missing attributes

2021-01-28 Thread Tim Wiederhake
If "udevGetDeviceSysfsAttr()" returns NULL, "udevGetIntSysfsAttr" would return "0", indicating success, without writing to "value". This was found by clang-tidy's "clang-analyzer-core.UndefinedBinaryOperatorResult" check in function "udevProcessCCW", flagging a read on the potentially