On Mon, Feb 14, 2022 at 04:56:37PM +, Daniel P. Berrangé wrote:
> On Mon, Feb 14, 2022 at 08:09:57AM -0800, Andrea Bolognani wrote:
> > > > Can you please provide pointers to the OpenStack implementation of
> > > > this and the issue that resulted from introducing virt-ssh-helper?
> > >
> > >
On Mon, Feb 14, 2022 at 08:09:57AM -0800, Andrea Bolognani wrote:
> On Mon, Feb 14, 2022 at 10:25:48AM +, Daniel P. Berrangé wrote:
> > > > I understand the motivation, but please don't change this. Applications
> > > > like OpenStack have configured ssh authorized_keys files with the
> > > >
On Mon, Feb 14, 2022 at 10:25:48AM +, Daniel P. Berrangé wrote:
> > > I understand the motivation, but please don't change this. Applications
> > > like OpenStack have configured ssh authorized_keys files with the
> > > specific command that libvirt invokes. So changes like this will break
> >
On Mon, Feb 14, 2022 at 01:56:17AM -0800, Andrea Bolognani wrote:
> On Fri, Feb 11, 2022 at 05:46:31PM +, Daniel P. Berrangé wrote:
> > > -return g_strdup_printf("sh -c 'which virt-ssh-helper 1>/dev/null
> > > 2>&1; "
> > > - "if test $? = 0; then "
> > >
On Fri, Feb 11, 2022 at 05:46:31PM +, Daniel P. Berrangé wrote:
> > -return g_strdup_printf("sh -c 'which virt-ssh-helper 1>/dev/null
> > 2>&1; "
> > - "if test $? = 0; then "
> > +return g_strdup_printf("sh -c 'if which virt-ssh-helper >/dev/null
On Fri, Feb 11, 2022 at 06:39:15PM +0100, Andrea Bolognani wrote:
> This makes the generated script a bit shorter and removes an
> unnecessary call to test.
>
> Signed-off-by: Andrea Bolognani
> ---
> src/rpc/virnetclient.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff
This makes the generated script a bit shorter and removes an
unnecessary call to test.
Signed-off-by: Andrea Bolognani
---
src/rpc/virnetclient.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c
index cbefa8f11f..7e7e9d52a6
