Re: [libvirt PATCH 09/20] ci: build.sh: Join MESON_ARGS and MESON_OPTS

2023-08-24 Thread Andrea Bolognani
On Wed, Aug 23, 2023 at 11:38:17AM +0200, Erik Skultety wrote: > On Mon, Aug 21, 2023 at 05:17:06AM -0700, Andrea Bolognani wrote: > > On Mon, Feb 06, 2023 at 02:53:06PM +0100, Erik Skultety wrote: > > > -meson setup build --werror -Dsystem=true $MESON_OPTS $MESON_ARGS || \ > > >

Re: [libvirt PATCH 09/20] ci: build.sh: Join MESON_ARGS and MESON_OPTS

2023-08-23 Thread Erik Skultety
On Mon, Aug 21, 2023 at 05:17:06AM -0700, Andrea Bolognani wrote: > Resurrecting this thread now what you've pushed some of the patches. > > On Mon, Feb 06, 2023 at 02:53:06PM +0100, Erik Skultety wrote: > > +# $MESON_ARGS correspond to meson's setup args, i.e. configure args. It's > > +#

Re: [libvirt PATCH 09/20] ci: build.sh: Join MESON_ARGS and MESON_OPTS

2023-08-21 Thread Andrea Bolognani
Resurrecting this thread now what you've pushed some of the patches. On Mon, Feb 06, 2023 at 02:53:06PM +0100, Erik Skultety wrote: > +# $MESON_ARGS correspond to meson's setup args, i.e. configure args. It's > +# populated either from a GitLab's job configuration or from command line as > +# `$

Re: [libvirt PATCH 09/20] ci: build.sh: Join MESON_ARGS and MESON_OPTS

2023-03-02 Thread Daniel P . Berrangé
On Mon, Feb 06, 2023 at 02:53:06PM +0100, Erik Skultety wrote: > It is quite confusing seeing these two in a call like this one: > $ meson build $MESON_OPTS $MESON_ARGS > > One has to ask 'how are they different' and 'shouldn't these be > merged'. In fact, these variables hold very different

[libvirt PATCH 09/20] ci: build.sh: Join MESON_ARGS and MESON_OPTS

2023-02-06 Thread Erik Skultety
It is quite confusing seeing these two in a call like this one: $ meson build $MESON_OPTS $MESON_ARGS One has to ask 'how are they different' and 'shouldn't these be merged'. In fact, these variables hold very different things and we should make it more obvious. The problem is that renaming