Re: [libvirt PATCH 1/1] conf: move graphics validation checks out of *ParseXML function.

2020-07-30 Thread Michal Privoznik
On 7/30/20 6:41 PM, Nicolás Brignone wrote: Hi!     Is this going to be merged? Do I need to do something else? Thanks! Hi, unfortunately it missed the feature freeze for the upcoming release. We are expecting the release to happen by start of the next week. I will merge it afterwards.

Re: [libvirt PATCH 1/1] conf: move graphics validation checks out of *ParseXML function.

2020-07-30 Thread Nicolás Brignone
Hi! Is this going to be merged? Do I need to do something else? Thanks! On Fri, Jul 24, 2020 at 5:08 PM Jonathon Jongsma wrote: > On Wed, 2020-07-22 at 14:56 -0300, Nicolas Brignone wrote: > > Existing virDomainDefPostParseGraphics function seems to be the right > > place to put this

Re: [libvirt PATCH 1/1] conf: move graphics validation checks out of *ParseXML function.

2020-07-24 Thread Jonathon Jongsma
On Wed, 2020-07-22 at 14:56 -0300, Nicolas Brignone wrote: > Existing virDomainDefPostParseGraphics function seems to be the right > place to put this validations. > > After moving this validation, one less argument is needed in > virDomainGraphicsListenDefParseXML, so removing the "graphics" >

[libvirt PATCH 1/1] conf: move graphics validation checks out of *ParseXML function.

2020-07-22 Thread Nicolas Brignone
Existing virDomainDefPostParseGraphics function seems to be the right place to put this validations. After moving this validation, one less argument is needed in virDomainGraphicsListenDefParseXML, so removing the "graphics" argument from the function signature. Signed-off-by: Nicolas Brignone