Re: [libvirt PATCH 1/5] nwfilter: stop using recursive mutex for IP learning

2022-02-28 Thread Daniel P . Berrangé
On Mon, Feb 28, 2022 at 11:05:09AM -0500, Laine Stump wrote: > On 2/25/22 10:30 AM, Daniel P. Berrangé wrote: > > The virNWFilterLockIface method is only called from one place, > > the learnIPAddressThread method. > > nwfilter_gentech_driver.c:virNWFilterDoInstantiate() and >

Re: [libvirt PATCH 1/5] nwfilter: stop using recursive mutex for IP learning

2022-02-28 Thread Laine Stump
On 2/25/22 10:30 AM, Daniel P. Berrangé wrote: The virNWFilterLockIface method is only called from one place, the learnIPAddressThread method. nwfilter_gentech_driver.c:virNWFilterDoInstantiate() and _virNWFilterTeardownFilter() also call virNWFilterLockIface. And there is this call chain

[libvirt PATCH 1/5] nwfilter: stop using recursive mutex for IP learning

2022-02-25 Thread Daniel P . Berrangé
The virNWFilterLockIface method is only called from one place, the learnIPAddressThread method. This is the entry point for the learning thread on the interface in question. As such there is never any recursive locking on this mutex from the same thread. This appears to have been the case since