Re: [libvirt PATCH 15/28] build: add nft to the list of binaries we attempt to locate

2023-05-05 Thread Daniel P . Berrangé
On Fri, May 05, 2023 at 02:04:01AM -0700, Andrea Bolognani wrote: > On Thu, May 04, 2023 at 02:21:57PM -0400, Laine Stump wrote: > > On 5/4/23 4:33 AM, Andrea Bolognani wrote: > > > I don't think we need the BuildRequires, or the build time detection, > > > at all. Just > > > > > >#define NFT

Re: [libvirt PATCH 15/28] build: add nft to the list of binaries we attempt to locate

2023-05-05 Thread Andrea Bolognani
On Thu, May 04, 2023 at 02:21:57PM -0400, Laine Stump wrote: > On 5/4/23 4:33 AM, Andrea Bolognani wrote: > > I don't think we need the BuildRequires, or the build time detection, > > at all. Just > > > >#define NFT "nft" > > > > in the relevant file and be done with it. We'll locate the

Re: [libvirt PATCH 15/28] build: add nft to the list of binaries we attempt to locate

2023-05-04 Thread Laine Stump
On 5/4/23 4:33 AM, Andrea Bolognani wrote: On Wed, May 03, 2023 at 04:26:21PM +0100, Daniel P. Berrangé wrote: On Sun, Apr 30, 2023 at 11:19:30PM -0400, Laine Stump wrote: and include it in BuildRequires and Requires of the rpm specfile to make sure it's available when doing official distro

Re: [libvirt PATCH 15/28] build: add nft to the list of binaries we attempt to locate

2023-05-04 Thread Andrea Bolognani
On Wed, May 03, 2023 at 04:26:21PM +0100, Daniel P. Berrangé wrote: > On Sun, Apr 30, 2023 at 11:19:30PM -0400, Laine Stump wrote: > > and include it in BuildRequires and Requires of the rpm specfile to > > make sure it's available when doing official distro builds. > > This new dep will need

Re: [libvirt PATCH 15/28] build: add nft to the list of binaries we attempt to locate

2023-05-03 Thread Daniel P . Berrangé
On Sun, Apr 30, 2023 at 11:19:30PM -0400, Laine Stump wrote: > and include it in BuildRequires and Requires of the rpm specfile to > make sure it's available when doing official distro builds. > > Signed-off-by: Laine Stump > --- > libvirt.spec.in | 2 ++ > meson.build | 1 + > 2 files

[libvirt PATCH 15/28] build: add nft to the list of binaries we attempt to locate

2023-04-30 Thread Laine Stump
and include it in BuildRequires and Requires of the rpm specfile to make sure it's available when doing official distro builds. Signed-off-by: Laine Stump --- libvirt.spec.in | 2 ++ meson.build | 1 + 2 files changed, 3 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index