Re: [libvirt PATCH 2/2] ci: Call meson consistently

2021-04-08 Thread Daniel P . Berrangé
On Thu, Apr 08, 2021 at 12:56:05PM +0200, Martin Kletzander wrote: > On Thu, Apr 08, 2021 at 11:39:55AM +0100, Daniel P. Berrangé wrote: > > On Thu, Apr 08, 2021 at 12:32:10PM +0200, Martin Kletzander wrote: > > > On Thu, Apr 01, 2021 at 03:43:11PM +0200, Andrea Bolognani wrote: > > > > On Wed,

Re: [libvirt PATCH 2/2] ci: Call meson consistently

2021-04-08 Thread Martin Kletzander
On Thu, Apr 08, 2021 at 11:39:55AM +0100, Daniel P. Berrangé wrote: On Thu, Apr 08, 2021 at 12:32:10PM +0200, Martin Kletzander wrote: On Thu, Apr 01, 2021 at 03:43:11PM +0200, Andrea Bolognani wrote: > On Wed, 2021-03-31 at 23:31 +0200, Martin Kletzander wrote: > > On Fri, Mar 26, 2021 at

Re: [libvirt PATCH 2/2] ci: Call meson consistently

2021-04-08 Thread Daniel P . Berrangé
On Thu, Apr 08, 2021 at 12:32:10PM +0200, Martin Kletzander wrote: > On Thu, Apr 01, 2021 at 03:43:11PM +0200, Andrea Bolognani wrote: > > On Wed, 2021-03-31 at 23:31 +0200, Martin Kletzander wrote: > > > On Fri, Mar 26, 2021 at 11:35:02AM +0100, Andrea Bolognani wrote: > > > > We should always

Re: [libvirt PATCH 2/2] ci: Call meson consistently

2021-04-08 Thread Martin Kletzander
On Thu, Apr 01, 2021 at 03:43:11PM +0200, Andrea Bolognani wrote: On Wed, 2021-03-31 at 23:31 +0200, Martin Kletzander wrote: On Fri, Mar 26, 2021 at 11:35:02AM +0100, Andrea Bolognani wrote: > We should always pass --werror and display the contents of the > log file in case of failure. Any

Re: [libvirt PATCH 2/2] ci: Call meson consistently

2021-04-01 Thread Andrea Bolognani
On Wed, 2021-03-31 at 23:31 +0200, Martin Kletzander wrote: > On Fri, Mar 26, 2021 at 11:35:02AM +0100, Andrea Bolognani wrote: > > We should always pass --werror and display the contents of the > > log file in case of failure. > > Any reason why the lines are not in one place? What I did in

Re: [libvirt PATCH 2/2] ci: Call meson consistently

2021-03-31 Thread Martin Kletzander
On Fri, Mar 26, 2021 at 11:35:02AM +0100, Andrea Bolognani wrote: We should always pass --werror and display the contents of the log file in case of failure. Any reason why the lines are not in one place? What I did in libnbd (first draft, still up for review) is that I just took all the

Re: [libvirt PATCH 2/2] ci: Call meson consistently

2021-03-31 Thread Martin Kletzander
On Mon, Mar 29, 2021 at 10:17:51AM +0200, Andrea Bolognani wrote: On Fri, 2021-03-26 at 18:55 +0100, Pavel Hrdina wrote: On Fri, Mar 26, 2021 at 05:11:04PM +0100, Andrea Bolognani wrote: > Even though you didn't spell that out explicitly, I assume you're > okay with me pushing this series

Re: [libvirt PATCH 2/2] ci: Call meson consistently

2021-03-29 Thread Andrea Bolognani
On Fri, 2021-03-26 at 18:55 +0100, Pavel Hrdina wrote: > On Fri, Mar 26, 2021 at 05:11:04PM +0100, Andrea Bolognani wrote: > > Even though you didn't spell that out explicitly, I assume you're > > okay with me pushing this series during the freeze? > > I know it's trivial and most likely will not

Re: [libvirt PATCH 2/2] ci: Call meson consistently

2021-03-28 Thread Erik Skultety
On Fri, Mar 26, 2021 at 05:11:04PM +0100, Andrea Bolognani wrote: > On Fri, 2021-03-26 at 17:00 +0100, Erik Skultety wrote: > > On Fri, Mar 26, 2021 at 11:35:02AM +0100, Andrea Bolognani wrote: > > > We should always pass --werror and display the contents of the > > > log file in case of failure.

Re: [libvirt PATCH 2/2] ci: Call meson consistently

2021-03-26 Thread Pavel Hrdina
On Fri, Mar 26, 2021 at 05:11:04PM +0100, Andrea Bolognani wrote: > On Fri, 2021-03-26 at 17:00 +0100, Erik Skultety wrote: > > On Fri, Mar 26, 2021 at 11:35:02AM +0100, Andrea Bolognani wrote: > > > We should always pass --werror and display the contents of the > > > log file in case of failure.

Re: [libvirt PATCH 2/2] ci: Call meson consistently

2021-03-26 Thread Andrea Bolognani
On Fri, 2021-03-26 at 17:00 +0100, Erik Skultety wrote: > On Fri, Mar 26, 2021 at 11:35:02AM +0100, Andrea Bolognani wrote: > > We should always pass --werror and display the contents of the > > log file in case of failure. > > > > Signed-off-by: Andrea Bolognani > > --- > Reviewed-by: Erik

Re: [libvirt PATCH 2/2] ci: Call meson consistently

2021-03-26 Thread Erik Skultety
On Fri, Mar 26, 2021 at 11:35:02AM +0100, Andrea Bolognani wrote: > We should always pass --werror and display the contents of the > log file in case of failure. > > Signed-off-by: Andrea Bolognani > --- Reviewed-by: Erik Skultety

[libvirt PATCH 2/2] ci: Call meson consistently

2021-03-26 Thread Andrea Bolognani
We should always pass --werror and display the contents of the log file in case of failure. Signed-off-by: Andrea Bolognani --- .gitlab-ci.yml | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index cbc1292839..8b7df68f47 100644 ---