Re: [libvirt PATCH 2/2] include: Explicitly reserve values for overlapping flag types

2022-05-05 Thread Daniel P . Berrangé
On Thu, May 05, 2022 at 04:58:10AM -0700, Andrea Bolognani wrote: > On Thu, May 05, 2022 at 11:40:55AM +0100, Daniel P. Berrangé wrote: > > On Thu, May 05, 2022 at 02:13:15AM -0700, Andrea Bolognani wrote: > > > On Thu, May 05, 2022 at 08:57:04AM +0100, Daniel P. Berrangé wrote: > > > > IMHO it is

Re: [libvirt PATCH 2/2] include: Explicitly reserve values for overlapping flag types

2022-05-05 Thread Andrea Bolognani
On Thu, May 05, 2022 at 11:40:55AM +0100, Daniel P. Berrangé wrote: > On Thu, May 05, 2022 at 02:13:15AM -0700, Andrea Bolognani wrote: > > On Thu, May 05, 2022 at 08:57:04AM +0100, Daniel P. Berrangé wrote: > > > IMHO it is pretty straightforward for apibuild.py to have a policy > > > that the

Re: [libvirt PATCH 2/2] include: Explicitly reserve values for overlapping flag types

2022-05-05 Thread Daniel P . Berrangé
On Thu, May 05, 2022 at 02:13:15AM -0700, Andrea Bolognani wrote: > On Thu, May 05, 2022 at 08:57:04AM +0100, Daniel P. Berrangé wrote: > > On Thu, May 05, 2022 at 09:48:54AM +0200, Victor Toso wrote: > > > On Wed, May 04, 2022 at 07:02:48PM +0100, Daniel P. Berrangé wrote: > > > > I don't really

Re: [libvirt PATCH 2/2] include: Explicitly reserve values for overlapping flag types

2022-05-05 Thread Andrea Bolognani
On Thu, May 05, 2022 at 08:57:04AM +0100, Daniel P. Berrangé wrote: > On Thu, May 05, 2022 at 09:48:54AM +0200, Victor Toso wrote: > > On Wed, May 04, 2022 at 07:02:48PM +0100, Daniel P. Berrangé wrote: > > > I don't really like the idea of adding stuff to the public API > > > to workaround

Re: [libvirt PATCH 2/2] include: Explicitly reserve values for overlapping flag types

2022-05-05 Thread Victor Toso
Hi, On Thu, May 05, 2022 at 08:57:04AM +0100, Daniel P. Berrangé wrote: > On Thu, May 05, 2022 at 09:48:54AM +0200, Victor Toso wrote: > > Hi, > > > > On Wed, May 04, 2022 at 07:02:48PM +0100, Daniel P. Berrangé wrote: > > > On Wed, May 04, 2022 at 07:30:08PM +0200, Andrea Bolognani wrote: > > >

Re: [libvirt PATCH 2/2] include: Explicitly reserve values for overlapping flag types

2022-05-05 Thread Daniel P . Berrangé
On Thu, May 05, 2022 at 09:48:54AM +0200, Victor Toso wrote: > Hi, > > On Wed, May 04, 2022 at 07:02:48PM +0100, Daniel P. Berrangé wrote: > > On Wed, May 04, 2022 at 07:30:08PM +0200, Andrea Bolognani wrote: > > > Due to hystorical reasons, it needs to be possible to pass values > > hystorical

Re: [libvirt PATCH 2/2] include: Explicitly reserve values for overlapping flag types

2022-05-05 Thread Victor Toso
Hi, On Wed, May 04, 2022 at 07:02:48PM +0100, Daniel P. Berrangé wrote: > On Wed, May 04, 2022 at 07:30:08PM +0200, Andrea Bolognani wrote: > > Due to hystorical reasons, it needs to be possible to pass values hystorical -> historical ? > > from the virTypedParameterFlags and

Re: [libvirt PATCH 2/2] include: Explicitly reserve values for overlapping flag types

2022-05-04 Thread Daniel P . Berrangé
On Wed, May 04, 2022 at 07:30:08PM +0200, Andrea Bolognani wrote: > Due to hystorical reasons, it needs to be possible to pass values > from the virTypedParameterFlags and virDomainModificationImpact > enumerations to a function at the same time, so it is very > important that the two never

[libvirt PATCH 2/2] include: Explicitly reserve values for overlapping flag types

2022-05-04 Thread Andrea Bolognani
Due to hystorical reasons, it needs to be possible to pass values from the virTypedParameterFlags and virDomainModificationImpact enumerations to a function at the same time, so it is very important that the two never overlap. Right now this is "enforced" by the presence of special comments;