Re: [libvirt PATCH 2/2] meson: Detect and reject invalid rst2html5 command

2021-11-03 Thread Andrea Bolognani
On Wed, Nov 03, 2021 at 10:26:12AM +, Daniel P. Berrangé wrote: > On Wed, Nov 03, 2021 at 04:15:49AM -0500, Andrea Bolognani wrote: > > Since no actual NACK has been raised over the past three months, nor > > has an alternative implementation materialized, I went ahead and > > pushed the

Re: [libvirt PATCH 2/2] meson: Detect and reject invalid rst2html5 command

2021-11-03 Thread Daniel P . Berrangé
On Wed, Nov 03, 2021 at 04:15:49AM -0500, Andrea Bolognani wrote: > On Wed, Oct 06, 2021 at 10:58:29AM -0500, Andrea Bolognani wrote: > > Dan, should I consider your criticism of the approach an explicit > > NACK? If not, I will pick up Pavel's ACK and push this. > > > > I think the latter is the

Re: [libvirt PATCH 2/2] meson: Detect and reject invalid rst2html5 command

2021-11-03 Thread Andrea Bolognani
On Wed, Oct 06, 2021 at 10:58:29AM -0500, Andrea Bolognani wrote: > Dan, should I consider your criticism of the approach an explicit > NACK? If not, I will pick up Pavel's ACK and push this. > > I think the latter is the right thing to do, on the basis that it > will leave us in a place that's

Re: [libvirt PATCH 2/2] meson: Detect and reject invalid rst2html5 command

2021-10-06 Thread Andrea Bolognani
On Tue, Aug 10, 2021 at 05:02:54AM -0700, Andrea Bolognani wrote: > On Tue, Aug 10, 2021 at 11:05:42AM +0100, Daniel P. Berrangé wrote: > > On Mon, Aug 09, 2021 at 05:13:29PM +0200, Andrea Bolognani wrote: > > > The version coming from the rst2html5 package instead of the > > > docutils package is

Re: [libvirt PATCH 2/2] meson: Detect and reject invalid rst2html5 command

2021-08-10 Thread Andrea Bolognani
On Tue, Aug 10, 2021 at 11:05:42AM +0100, Daniel P. Berrangé wrote: > On Mon, Aug 09, 2021 at 05:13:29PM +0200, Andrea Bolognani wrote: > > The version coming from the rst2html5 package instead of the > > docutils package is unable to successfully generate the libvirt > > documentation. > > > >

Re: [libvirt PATCH 2/2] meson: Detect and reject invalid rst2html5 command

2021-08-10 Thread Daniel P . Berrangé
On Mon, Aug 09, 2021 at 05:13:29PM +0200, Andrea Bolognani wrote: > The version coming from the rst2html5 package instead of the > docutils package is unable to successfully generate the libvirt > documentation. > > Examples of users encountering build issues because of the wrong > version of

[libvirt PATCH 2/2] meson: Detect and reject invalid rst2html5 command

2021-08-09 Thread Andrea Bolognani
The version coming from the rst2html5 package instead of the docutils package is unable to successfully generate the libvirt documentation. Examples of users encountering build issues because of the wrong version of rst2html5 being installed on their systems: