Re: [libvirt PATCH 2/3] nodedev: Handle NULL command variable

2021-06-15 Thread Peter Krempa
On Tue, Jun 15, 2021 at 11:28:39 -0500, Jonathon Jongsma wrote: > In commit 68580a51, I removed the checks for NULL cmd variables because > virCommandRun() already handles the case where it is called with a NULL > cmd. Unfortunately, it handles this case by raising a generic error > which is both u

[libvirt PATCH 2/3] nodedev: Handle NULL command variable

2021-06-15 Thread Jonathon Jongsma
In commit 68580a51, I removed the checks for NULL cmd variables because virCommandRun() already handles the case where it is called with a NULL cmd. Unfortunately, it handles this case by raising a generic error which is both unhelpful and overwrites our existing error message. So for example, when