Re: [libvirt PATCH 26/42] systemd: Switch virtchd to common templates

2023-09-26 Thread Andrea Bolognani
On Tue, Sep 26, 2023 at 01:14:33PM +0100, Daniel P. Berrangé wrote: > On Tue, Sep 26, 2023 at 07:02:19AM -0500, Andrea Bolognani wrote: > > I don't think it helps much with not storing additional data inside > > the build system, unless we want to store the contents of the various > > common snippe

Re: [libvirt PATCH 26/42] systemd: Switch virtchd to common templates

2023-09-26 Thread Daniel P . Berrangé
On Tue, Sep 26, 2023 at 08:12:43AM -0500, Andrea Bolognani wrote: > On Tue, Sep 26, 2023 at 01:14:33PM +0100, Daniel P. Berrangé wrote: > > On Tue, Sep 26, 2023 at 07:02:19AM -0500, Andrea Bolognani wrote: > > > I don't think it helps much with not storing additional data inside > > > the build sys

Re: [libvirt PATCH 26/42] systemd: Switch virtchd to common templates

2023-09-26 Thread Andrea Bolognani
On Tue, Sep 26, 2023 at 11:23:51AM +0100, Daniel P. Berrangé wrote: > On Tue, Sep 26, 2023 at 11:09:44AM +0200, Pavel Hrdina wrote: > > On Mon, Sep 25, 2023 at 08:58:24PM +0200, Andrea Bolognani wrote: > > > +'service_unit_extra': [ > > > + 'Wants=systemd-machined.service', > > > + 'A

Re: [libvirt PATCH 26/42] systemd: Switch virtchd to common templates

2023-09-26 Thread Daniel P . Berrangé
On Tue, Sep 26, 2023 at 07:02:19AM -0500, Andrea Bolognani wrote: > On Tue, Sep 26, 2023 at 11:23:51AM +0100, Daniel P. Berrangé wrote: > > On Tue, Sep 26, 2023 at 11:09:44AM +0200, Pavel Hrdina wrote: > > > On Mon, Sep 25, 2023 at 08:58:24PM +0200, Andrea Bolognani wrote: > > > > +'service_uni

Re: [libvirt PATCH 26/42] systemd: Switch virtchd to common templates

2023-09-26 Thread Daniel P . Berrangé
On Tue, Sep 26, 2023 at 11:09:44AM +0200, Pavel Hrdina wrote: > On Mon, Sep 25, 2023 at 08:58:24PM +0200, Andrea Bolognani wrote: > > Signed-off-by: Andrea Bolognani > > --- > > src/ch/meson.build| 27 > > src/ch/virtchd.service.in | 44 ---

Re: [libvirt PATCH 26/42] systemd: Switch virtchd to common templates

2023-09-26 Thread Andrea Bolognani
On Tue, Sep 26, 2023 at 11:09:44AM +0200, Pavel Hrdina wrote: > On Mon, Sep 25, 2023 at 08:58:24PM +0200, Andrea Bolognani wrote: > > +'service_unit_extra': [ > > + 'Wants=systemd-machined.service', > > + 'After=systemd-machined.service', > > + 'After=remote-fs.target', > > +

Re: [libvirt PATCH 26/42] systemd: Switch virtchd to common templates

2023-09-26 Thread Pavel Hrdina
On Mon, Sep 25, 2023 at 08:58:24PM +0200, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > src/ch/meson.build| 27 > src/ch/virtchd.service.in | 44 --- > 2 files changed, 23 insertions(+), 48 deletions(-) > de

[libvirt PATCH 26/42] systemd: Switch virtchd to common templates

2023-09-25 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- src/ch/meson.build| 27 src/ch/virtchd.service.in | 44 --- 2 files changed, 23 insertions(+), 48 deletions(-) delete mode 100644 src/ch/virtchd.service.in diff --git a/src/ch/meson.build b/