Re: [libvirt PATCH 3/3] qemu: block: external snapshot-delete implementation for straightforward cases

2020-04-23 Thread Pavel Mores
On Wed, Apr 22, 2020 at 03:49:57PM +0200, Peter Krempa wrote: > On Thu, Apr 16, 2020 at 17:07:35 +0200, Pavel Mores wrote: > > On Fri, Apr 03, 2020 at 05:56:59PM +0200, Pavel Mores wrote: > > > On Tue, Mar 31, 2020 at 12:06:15PM +0200, Peter Krempa wrote: > > > > On Tue, Mar 31, 2020 at 11:18:29

Re: [libvirt PATCH 3/3] qemu: block: external snapshot-delete implementation for straightforward cases

2020-04-22 Thread Peter Krempa
On Thu, Apr 16, 2020 at 17:07:35 +0200, Pavel Mores wrote: > On Fri, Apr 03, 2020 at 05:56:59PM +0200, Pavel Mores wrote: > > On Tue, Mar 31, 2020 at 12:06:15PM +0200, Peter Krempa wrote: > > > On Tue, Mar 31, 2020 at 11:18:29 +0200, Pavel Mores wrote: > > > > +} > > > > + > > > > +

Re: [libvirt PATCH 3/3] qemu: block: external snapshot-delete implementation for straightforward cases

2020-04-16 Thread Pavel Mores
On Fri, Apr 03, 2020 at 05:56:59PM +0200, Pavel Mores wrote: > On Tue, Mar 31, 2020 at 12:06:15PM +0200, Peter Krempa wrote: > > On Tue, Mar 31, 2020 at 11:18:29 +0200, Pavel Mores wrote: > > > +} > > > + > > > +if (flags & VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN) > > > +

Re: [libvirt PATCH 3/3] qemu: block: external snapshot-delete implementation for straightforward cases

2020-04-03 Thread Pavel Mores
On Tue, Mar 31, 2020 at 12:06:15PM +0200, Peter Krempa wrote: > On Tue, Mar 31, 2020 at 11:18:29 +0200, Pavel Mores wrote: > > +} > > + > > +if (flags & VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN) > > +topPath = disk->src->path; > > +else > > +

Re: [libvirt PATCH 3/3] qemu: block: external snapshot-delete implementation for straightforward cases

2020-04-03 Thread Pavel Mores
On Fri, Apr 03, 2020 at 02:36:35PM +0200, Peter Krempa wrote: > On Fri, Apr 03, 2020 at 14:34:29 +0200, Pavel Mores wrote: > > On Tue, Mar 31, 2020 at 12:06:15PM +0200, Peter Krempa wrote: > > > On Tue, Mar 31, 2020 at 11:18:29 +0200, Pavel Mores wrote: > > > > > > > +} > > > > + > >

Re: [libvirt PATCH 3/3] qemu: block: external snapshot-delete implementation for straightforward cases

2020-04-03 Thread Pavel Mores
On Tue, Mar 31, 2020 at 12:06:15PM +0200, Peter Krempa wrote: > On Tue, Mar 31, 2020 at 11:18:29 +0200, Pavel Mores wrote: > > > +} > > + > > +if (flags & VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN) > > +topPath = disk->src->path; > > +else > > +

Re: [libvirt PATCH 3/3] qemu: block: external snapshot-delete implementation for straightforward cases

2020-04-03 Thread Peter Krempa
On Fri, Apr 03, 2020 at 14:34:29 +0200, Pavel Mores wrote: > On Tue, Mar 31, 2020 at 12:06:15PM +0200, Peter Krempa wrote: > > On Tue, Mar 31, 2020 at 11:18:29 +0200, Pavel Mores wrote: > > > > > +} > > > + > > > +if (flags & VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN) > > > +

Re: [libvirt PATCH 3/3] qemu: block: external snapshot-delete implementation for straightforward cases

2020-03-31 Thread Peter Krempa
On Tue, Mar 31, 2020 at 11:18:29 +0200, Pavel Mores wrote: > Works by blockcommitting the snapshot to be deleted into its parent. Handles > both deleting children as well and deleting children only (commits the > children into the snapshot referred to by snapshot-delete argument). If the >

[libvirt PATCH 3/3] qemu: block: external snapshot-delete implementation for straightforward cases

2020-03-31 Thread Pavel Mores
Works by blockcommitting the snapshot to be deleted into its parent. Handles both deleting children as well and deleting children only (commits the children into the snapshot referred to by snapshot-delete argument). If the necessary block commit operation turns out to be active (the snapshot