Re: [libvirt PATCH 3/6] qemu: block: blockpull param 'top' support in virsh proper

2020-03-04 Thread Pavel Mores
On Wed, Mar 04, 2020 at 03:13:41PM +0100, Peter Krempa wrote: > On Wed, Mar 04, 2020 at 15:01:07 +0100, Pavel Mores wrote: > > On Wed, Mar 04, 2020 at 02:53:53PM +0100, Peter Krempa wrote: > > > On Wed, Mar 04, 2020 at 14:41:09 +0100, Pavel Mores wrote: > > > > On Wed, Mar 04, 2020 at 01:00:59PM

Re: [libvirt PATCH 3/6] qemu: block: blockpull param 'top' support in virsh proper

2020-03-04 Thread Peter Krempa
On Wed, Mar 04, 2020 at 15:01:07 +0100, Pavel Mores wrote: > On Wed, Mar 04, 2020 at 02:53:53PM +0100, Peter Krempa wrote: > > On Wed, Mar 04, 2020 at 14:41:09 +0100, Pavel Mores wrote: > > > On Wed, Mar 04, 2020 at 01:00:59PM +0100, Peter Krempa wrote: > > > > On Wed, Mar 04, 2020 at 11:12:37

Re: [libvirt PATCH 3/6] qemu: block: blockpull param 'top' support in virsh proper

2020-03-04 Thread Pavel Mores
On Wed, Mar 04, 2020 at 02:53:53PM +0100, Peter Krempa wrote: > On Wed, Mar 04, 2020 at 14:41:09 +0100, Pavel Mores wrote: > > On Wed, Mar 04, 2020 at 01:00:59PM +0100, Peter Krempa wrote: > > > On Wed, Mar 04, 2020 at 11:12:37 +0100, Pavel Mores wrote: > > > > A new command-line option --top was

Re: [libvirt PATCH 3/6] qemu: block: blockpull param 'top' support in virsh proper

2020-03-04 Thread Peter Krempa
On Wed, Mar 04, 2020 at 14:55:30 +0100, Pavel Mores wrote: > On Wed, Mar 04, 2020 at 02:41:09PM +0100, Pavel Mores wrote: > > On Wed, Mar 04, 2020 at 01:00:59PM +0100, Peter Krempa wrote: > > > On Wed, Mar 04, 2020 at 11:12:37 +0100, Pavel Mores wrote: > > > > A new command-line option --top was

Re: [libvirt PATCH 3/6] qemu: block: blockpull param 'top' support in virsh proper

2020-03-04 Thread Pavel Mores
On Wed, Mar 04, 2020 at 02:41:09PM +0100, Pavel Mores wrote: > On Wed, Mar 04, 2020 at 01:00:59PM +0100, Peter Krempa wrote: > > On Wed, Mar 04, 2020 at 11:12:37 +0100, Pavel Mores wrote: > > > A new command-line option --top was added to virsh's blockpull command. > > > Similar to how --base is

Re: [libvirt PATCH 3/6] qemu: block: blockpull param 'top' support in virsh proper

2020-03-04 Thread Peter Krempa
On Wed, Mar 04, 2020 at 14:41:09 +0100, Pavel Mores wrote: > On Wed, Mar 04, 2020 at 01:00:59PM +0100, Peter Krempa wrote: > > On Wed, Mar 04, 2020 at 11:12:37 +0100, Pavel Mores wrote: > > > A new command-line option --top was added to virsh's blockpull command. > > > Similar to how --base is

Re: [libvirt PATCH 3/6] qemu: block: blockpull param 'top' support in virsh proper

2020-03-04 Thread Pavel Mores
On Wed, Mar 04, 2020 at 01:00:59PM +0100, Peter Krempa wrote: > On Wed, Mar 04, 2020 at 11:12:37 +0100, Pavel Mores wrote: > > A new command-line option --top was added to virsh's blockpull command. > > Similar to how --base is handled, in presence of --top the operation is > > implemented

Re: [libvirt PATCH 3/6] qemu: block: blockpull param 'top' support in virsh proper

2020-03-04 Thread Peter Krempa
On Wed, Mar 04, 2020 at 11:12:37 +0100, Pavel Mores wrote: > A new command-line option --top was added to virsh's blockpull command. > Similar to how --base is handled, in presence of --top the operation is > implemented internally as a rebase. To that end, a corresponding new 'top' > parameter

[libvirt PATCH 3/6] qemu: block: blockpull param 'top' support in virsh proper

2020-03-04 Thread Pavel Mores
A new command-line option --top was added to virsh's blockpull command. Similar to how --base is handled, in presence of --top the operation is implemented internally as a rebase. To that end, a corresponding new 'top' parameter was added to virDomainBlockRebase(). Signed-off-by: Pavel Mores