Re: [libvirt PATCH 3/7] qemuxml2argvtest: Unlock virDomainObj before disposal

2021-08-05 Thread Peter Krempa
On Thu, Aug 05, 2021 at 15:08:47 +0200, Tim Wiederhake wrote: > virDomainObj contains a mutex. Destroying a locked mutex results in > undefined behavior. I presume all of the unlocks you've added are purely based on success code paths you've observed, right? > > Signed-off-by: Tim Wiederhake >

[libvirt PATCH 3/7] qemuxml2argvtest: Unlock virDomainObj before disposal

2021-08-05 Thread Tim Wiederhake
virDomainObj contains a mutex. Destroying a locked mutex results in undefined behavior. Signed-off-by: Tim Wiederhake --- tests/qemuxml2argvtest.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index