Re: [libvirt PATCH 4/4] ci: Halt on sanitizer errors

2021-07-22 Thread Tim Wiederhake
On Wed, 2021-07-21 at 06:56 -0700, Andrea Bolognani wrote: > On Wed, Jul 21, 2021 at 03:08:02PM +0200, Peter Krempa wrote: > > On Wed, Jul 21, 2021 at 14:46:43 +0200, Tim Wiederhake wrote: > > > +++ b/.gitlab-ci.yml > > > @@ -89,6 +89,8 @@ stages: > > > - meson build --werror -Ddocs=disabled

Re: [libvirt PATCH 4/4] ci: Halt on sanitizer errors

2021-07-21 Thread Daniel P . Berrangé
On Wed, Jul 21, 2021 at 03:08:02PM +0200, Peter Krempa wrote: > On Wed, Jul 21, 2021 at 14:46:43 +0200, Tim Wiederhake wrote: > > The undefined behaviour sanitizer (UBSAN) defaults to merely printing an > > error message if it detects undefined behaviour. These error messages often > > end up in

Re: [libvirt PATCH 4/4] ci: Halt on sanitizer errors

2021-07-21 Thread Andrea Bolognani
On Wed, Jul 21, 2021 at 03:08:02PM +0200, Peter Krempa wrote: > On Wed, Jul 21, 2021 at 14:46:43 +0200, Tim Wiederhake wrote: > > +++ b/.gitlab-ci.yml > > @@ -89,6 +89,8 @@ stages: > > - meson build --werror -Ddocs=disabled -Db_lundef=false > > -Db_sanitize="$SANITIZER" > > - ninja -C

Re: [libvirt PATCH 4/4] ci: Halt on sanitizer errors

2021-07-21 Thread Peter Krempa
On Wed, Jul 21, 2021 at 14:46:43 +0200, Tim Wiederhake wrote: > The undefined behaviour sanitizer (UBSAN) defaults to merely printing an > error message if it detects undefined behaviour. These error messages often > end up in captured output and do not fail the tests, effectively hiding > the

[libvirt PATCH 4/4] ci: Halt on sanitizer errors

2021-07-21 Thread Tim Wiederhake
The undefined behaviour sanitizer (UBSAN) defaults to merely printing an error message if it detects undefined behaviour. These error messages often end up in captured output and do not fail the tests, effectively hiding the warning. Make the test cases fail to make the issues visible.