Re: [libvirt PATCH 5/5] domain_conf: Fix check for hyperv stimer

2021-03-04 Thread Michal Privoznik
On 3/4/21 9:35 AM, Tim Wiederhake wrote: VIR_DOMAIN_HYPERV_STIMER happens to have the same numerical value as VIR_DOMAIN_FEATURE_HYPERV, resulting in the if-block to always being executed when a "" tag is found, whether or not it actually contained a "" tag. This had no ill effects, as

[libvirt PATCH 5/5] domain_conf: Fix check for hyperv stimer

2021-03-04 Thread Tim Wiederhake
VIR_DOMAIN_HYPERV_STIMER happens to have the same numerical value as VIR_DOMAIN_FEATURE_HYPERV, resulting in the if-block to always being executed when a "" tag is found, whether or not it actually contained a "" tag. This had no ill effects, as virXPathNodeSet() would simply return 0 if that tag